Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 34e048130ef74dbb1941e69ecab9b4d3dba211a7
https://github.com/WebKit/WebKit/commit/34e048130ef74dbb1941e69ecab9b4d3dba211a7
Author: Chris Dumez <[email protected]>
Date: 2026-05-04 (Mon, 04 May 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKNavigationResponse.mm
Log Message:
-----------
[Tahoe Debug] TestWebKitAPI.WebKit.WKNavigationResponseDownloadAttribute is
flaky failure
https://bugs.webkit.org/show_bug.cgi?id=308071
rdar://170575820
Reviewed by Per Arne Vollan.
The test's HTTP server used connection-based sequential request handling,
expecting both the initial page load and the link click navigation to
arrive on the same TCP connection. When the browser opened a new
connection for the second request, the server would serve the HTML body
instead of the Content-Disposition response, producing a suggestedFilename
of "fromHref.txt.html" instead of "fromHeader.txt".
Switch to path-based routing so each URL gets the correct response
regardless of which connection the request arrives on. Also remove the
DISABLED_ guard for macOS 26+ since this fixes the underlying flakiness.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKNavigationResponse.mm:
(TEST(WebKit, WKNavigationResponseDownloadAttribute)):
Canonical link: https://commits.webkit.org/312583@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
