Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6e84ca1cf0099237672d4d2e51ff7965a20e0c5a
https://github.com/WebKit/WebKit/commit/6e84ca1cf0099237672d4d2e51ff7965a20e0c5a
Author: Sihui Liu <[email protected]>
Date: 2026-05-04 (Mon, 04 May 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WebsiteDataStoreCustomPaths.mm
Log Message:
-----------
Re-enable WebsiteDataStoreCustomPaths API tests
https://bugs.webkit.org/show_bug.cgi?id=314006
rdar://176205715
Reviewed by Chris Dumez.
Use a custom general storage directory for the tests so they do not share the
default directory with other API tests.
When the default directory is shared, origins written by other tests are picked
up by getAllOrigins(). Some of those
origins use custom schemes (e.g. sw-ext://) that were registered as scheme
handlers in the original test but are not
registered in the WebsiteDataStoreCustomPaths test process. When such an origin
is reconstructed from on-disk data,
SecurityOriginData::shouldTreatAsOpaqueOrigin() treats it as opaque, so
optionalDatabaseIdentifier() returns an empty
string. This makes LocalStorageManager::localStorageFilePath() return an empty
path even though the custom local storage
directory is set, which triggers the assertion in OriginStorageManager that the
custom path and root path must both be
empty or both be non-empty.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WebsiteDataStoreCustomPaths.mm:
(runWebsiteDataStoreCustomPaths):
(TEST(WebKit, WebsiteDataStoreCustomPathsWithoutPrewarming)):
(TEST(WebKit, WebsiteDataStoreCustomPathsWithPrewarming)):
Canonical link: https://commits.webkit.org/312584@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
