Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1c3efb7fb8736d313583866d3d31922ce5e2b842
https://github.com/WebKit/WebKit/commit/1c3efb7fb8736d313583866d3d31922ce5e2b842
Author: Dan Glastonbury <[email protected]>
Date: 2026-05-04 (Mon, 04 May 2026)
Changed paths:
M Source/WebKit/UIProcess/XR/xros/PlatformXRCompositor.h
M Source/WebKit/UIProcess/XR/xros/PlatformXRCompositor.mm
M Source/WebKit/UIProcess/XR/xros/PlatformXRSystemXROS.mm
Log Message:
-----------
[WebXR] Remove use of WeakPtr in PlatformXRCompositor
https://bugs.webkit.org/show_bug.cgi?id=313948
rdar://175742141
Reviewed by Chris Dumez.
CompositorCoordinator is a LazyNeverDestroyed singleton, so
WeakPtr<CompositorCoordinator> is unnecessary. Add a static `singleton()` getter
and replace WeakPtr{*this} captures in callbacks with plain `this`
captures. Remove `CanMakeWeakPtr` and the deprecated exception.
Also replace WTF_DEPRECATED_MAKE_FAST_ALLOCATED with WTF_MAKE_TZONE_ALLOCATED,
and fix the startSession callback to properly promote WeakPtr<WebPageProxy> to
RefPtr.
* Source/WebKit/UIProcess/XR/xros/PlatformXRCompositor.h:
* Source/WebKit/UIProcess/XR/xros/PlatformXRCompositor.mm:
(WebKit::CompositorCoordinator::singleton):
(WebKit::CompositorCoordinator::requestPermissionOnSessionFeatures):
(WebKit::CompositorCoordinator::startSession):
* Source/WebKit/UIProcess/XR/xros/PlatformXRSystemXROS.mm:
(WebKit::PlatformXRSystem::xrCoordinator):
Canonical link: https://commits.webkit.org/312585@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
