Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1b01b6d32c396d50e97c949ac2bf82052dc4bb18
https://github.com/WebKit/WebKit/commit/1b01b6d32c396d50e97c949ac2bf82052dc4bb18
Author: Sam Weinig <[email protected]>
Date: 2026-05-08 (Fri, 08 May 2026)
Changed paths:
A
LayoutTests/webanimations/threaded-animations/threaded-animation-offset-path-margin-box-crash-expected.txt
A
LayoutTests/webanimations/threaded-animations/threaded-animation-offset-path-margin-box-crash.html
M Source/WebCore/platform/animation/values/paths/AcceleratedEffectCoordBox.h
M Source/WebCore/style/values/shapes/StylePathOperationWrappers.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
Log Message:
-----------
[threaded-animations] animating `offset-path` between `margin-box` and
`stroke-box` yields a crash under
`AcceleratedEffectValues::AcceleratedEffectValues(WebCore::RenderStyle const&,
WebCore::IntRect const&, WebCore::RenderLayerModelObject const*)`
https://bugs.webkit.org/show_bug.cgi?id=314105
Reviewed by Antoine Quint.
Add missing support for `margin-box` to AcceleratedEffectCoordBox.
The reason it was originally omitted was due to some spec/name
confusion. The Motion Path spec calls for the use of `<coord-box>`
which does not include 'margin-box', however, we currently parse
and store a `<geometry-box>` value, which does include 'margin-box',
matching a few examples in the spec and WPT. The spec issue is
tracked in https://github.com/w3c/fxtf-drafts/issues/481.
Test:
webanimations/threaded-animations/threaded-animation-offset-path-margin-box-crash.html
*
LayoutTests/webanimations/threaded-animations/threaded-animation-offset-path-margin-box-crash-expected.txt:
Added.
*
LayoutTests/webanimations/threaded-animations/threaded-animation-offset-path-margin-box-crash.html:
Added.
* Source/WebCore/platform/animation/values/paths/AcceleratedEffectCoordBox.h:
* Source/WebCore/style/values/shapes/StylePathOperationWrappers.cpp:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
Canonical link: https://commits.webkit.org/312881@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
