Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8b2c5738d4aac371267b4c01ecf82b76d5943995
https://github.com/WebKit/WebKit/commit/8b2c5738d4aac371267b4c01ecf82b76d5943995
Author: Sam Weinig <[email protected]>
Date: 2026-05-08 (Fri, 08 May 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-template-columns-rows-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-values/signs-abs-computed-expected.txt
M Source/WebCore/Headers.cmake
M
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/css/CSSGridAutoFlowValue.cpp
A Source/WebCore/css/CSSGridAutoFlowValue.h
R Source/WebCore/css/CSSGridAutoRepeatValue.cpp
R Source/WebCore/css/CSSGridAutoRepeatValue.h
R Source/WebCore/css/CSSGridIntegerRepeatValue.cpp
R Source/WebCore/css/CSSGridIntegerRepeatValue.h
R Source/WebCore/css/CSSGridLineNamesValue.cpp
R Source/WebCore/css/CSSGridLineNamesValue.h
M Source/WebCore/css/CSSGridLineValue.cpp
M Source/WebCore/css/CSSGridLineValue.h
A Source/WebCore/css/CSSGridTemplateListValue.cpp
A Source/WebCore/css/CSSGridTemplateListValue.h
A Source/WebCore/css/CSSGridTrackSizesValue.cpp
A Source/WebCore/css/CSSGridTrackSizesValue.h
M Source/WebCore/css/CSSProperties.json
R Source/WebCore/css/CSSSubgridValue.cpp
R Source/WebCore/css/CSSSubgridValue.h
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/ShorthandSerializer.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Grid.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Grid.h
M Source/WebCore/css/parser/CSSPropertyParserCustom.h
M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp
A Source/WebCore/css/values/grid/CSSGridAutoFlow.cpp
A Source/WebCore/css/values/grid/CSSGridAutoFlow.h
A Source/WebCore/css/values/grid/CSSGridLine.cpp
A Source/WebCore/css/values/grid/CSSGridLine.h
A Source/WebCore/css/values/grid/CSSGridLineNames.cpp
A Source/WebCore/css/values/grid/CSSGridLineNames.h
A Source/WebCore/css/values/grid/CSSGridSubgrid.cpp
A Source/WebCore/css/values/grid/CSSGridSubgrid.h
A Source/WebCore/css/values/grid/CSSGridTemplateList.cpp
A Source/WebCore/css/values/grid/CSSGridTemplateList.h
A Source/WebCore/css/values/grid/CSSGridTrackBreadth.h
A Source/WebCore/css/values/grid/CSSGridTrackList.h
A Source/WebCore/css/values/grid/CSSGridTrackSize.h
A Source/WebCore/css/values/grid/CSSGridTrackSizes.cpp
A Source/WebCore/css/values/grid/CSSGridTrackSizes.h
M Source/WebCore/css/values/primitives/CSSPrimitiveNumeric.h
M Source/WebCore/css/values/primitives/CSSPrimitiveNumericRange.h
M Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.h
M Source/WebCore/inspector/InspectorOverlay.cpp
M Source/WebCore/layout/formattingContexts/grid/GridFormattingContext.cpp
M Source/WebCore/layout/integration/grid/LayoutIntegrationGridCoverage.cpp
M Source/WebCore/style/StyleExtractorCustom.h
M Source/WebCore/style/StyleOrderedNamedLinesCollector.h
M Source/WebCore/style/values/grid/StyleGridAutoFlow.cpp
M Source/WebCore/style/values/grid/StyleGridAutoFlow.h
A Source/WebCore/style/values/grid/StyleGridLineNames.cpp
A Source/WebCore/style/values/grid/StyleGridLineNames.h
M Source/WebCore/style/values/grid/StyleGridNamedLinesMap.h
M Source/WebCore/style/values/grid/StyleGridOrderedNamedLinesMap.h
M Source/WebCore/style/values/grid/StyleGridPosition.cpp
M Source/WebCore/style/values/grid/StyleGridPosition.h
M Source/WebCore/style/values/grid/StyleGridTemplateList.cpp
M Source/WebCore/style/values/grid/StyleGridTemplateList.h
M Source/WebCore/style/values/grid/StyleGridTrackBreadth.cpp
M Source/WebCore/style/values/grid/StyleGridTrackBreadth.h
M Source/WebCore/style/values/grid/StyleGridTrackSize.cpp
M Source/WebCore/style/values/grid/StyleGridTrackSize.h
M Source/WebCore/style/values/grid/StyleGridTrackSizes.cpp
M Source/WebCore/style/values/grid/StyleGridTrackSizes.h
M Source/WebCore/style/values/primitives/StyleLengthWrapper.h
M Tools/TestWebKitAPI/Tests/WebCore/CSSParser.cpp
Log Message:
-----------
[CSS] Convert grid properties to use strong CSS types
https://bugs.webkit.org/show_bug.cgi?id=313982
Reviewed by Darin Adler.
Adds strong CSS types for the grid properties, updating parsing, serialization
and conversion to use the types.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-values/signs-abs-computed-expected.txt:
- This now passes a few more subtests due to correctly parsing <flex> calc()
*
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-template-columns-rows-expected.txt:
- These now report 2 subtests each as failing, but it seems like the test is
wrong. The test is setting a negative <flex> value, which now succeeds due
to the corrected <flex> calc() parsing, since the negative flex gets
wrapped
in a calc() value by the setter.
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSGridAutoFlowValue.cpp: Added.
* Source/WebCore/css/CSSGridAutoFlowValue.h: Added.
* Source/WebCore/css/CSSGridAutoRepeatValue.cpp: Removed.
* Source/WebCore/css/CSSGridAutoRepeatValue.h: Removed.
* Source/WebCore/css/CSSGridIntegerRepeatValue.cpp: Removed.
* Source/WebCore/css/CSSGridIntegerRepeatValue.h: Removed.
* Source/WebCore/css/CSSGridLineNamesValue.cpp: Removed.
* Source/WebCore/css/CSSGridLineNamesValue.h: Removed.
* Source/WebCore/css/CSSGridLineValue.cpp:
* Source/WebCore/css/CSSGridLineValue.h:
* Source/WebCore/css/CSSGridTemplateListValue.cpp: Added.
* Source/WebCore/css/CSSGridTemplateListValue.h: Added.
* Source/WebCore/css/CSSGridTrackSizesValue.cpp: Added.
* Source/WebCore/css/CSSGridTrackSizesValue.h: Added.
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSSubgridValue.cpp: Removed.
* Source/WebCore/css/CSSSubgridValue.h: Removed.
* Source/WebCore/css/CSSValue.cpp:
* Source/WebCore/css/CSSValue.h:
* Source/WebCore/css/ShorthandSerializer.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Grid.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Grid.h:
* Source/WebCore/css/parser/CSSPropertyParserCustom.h:
* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
* Source/WebCore/css/values/grid/CSSGridAutoFlow.cpp: Copied from
Source/WebCore/style/values/grid/StyleGridTrackSizes.cpp.
* Source/WebCore/css/values/grid/CSSGridAutoFlow.h: Copied from
Source/WebCore/style/values/grid/StyleGridAutoFlow.h.
* Source/WebCore/css/values/grid/CSSGridLine.cpp: Added.
* Source/WebCore/css/values/grid/CSSGridLine.h: Added.
* Source/WebCore/css/values/grid/CSSGridLineNames.cpp: Added.
* Source/WebCore/css/values/grid/CSSGridLineNames.h: Added.
* Source/WebCore/css/values/grid/CSSGridSubgrid.cpp: Added.
* Source/WebCore/css/values/grid/CSSGridSubgrid.h: Added.
* Source/WebCore/css/values/grid/CSSGridTemplateList.cpp: Added.
* Source/WebCore/css/values/grid/CSSGridTemplateList.h: Added.
* Source/WebCore/css/values/grid/CSSGridTrackBreadth.h: Added.
* Source/WebCore/css/values/grid/CSSGridTrackList.h: Added.
* Source/WebCore/css/values/grid/CSSGridTrackSize.h: Added.
* Source/WebCore/css/values/grid/CSSGridTrackSizes.cpp: Added.
* Source/WebCore/css/values/grid/CSSGridTrackSizes.h: Added.
* Source/WebCore/css/values/primitives/CSSPrimitiveNumeric.h:
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericRange.h:
* Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.h:
* Source/WebCore/inspector/InspectorOverlay.cpp:
* Source/WebCore/layout/formattingContexts/grid/GridFormattingContext.cpp:
* Source/WebCore/layout/integration/grid/LayoutIntegrationGridCoverage.cpp:
* Source/WebCore/style/StyleExtractorCustom.h:
* Source/WebCore/style/StyleOrderedNamedLinesCollector.h:
* Source/WebCore/style/values/grid/StyleGridAutoFlow.cpp:
* Source/WebCore/style/values/grid/StyleGridAutoFlow.h:
* Source/WebCore/style/values/grid/StyleGridLineNames.cpp: Added.
* Source/WebCore/style/values/grid/StyleGridLineNames.h: Added.
* Source/WebCore/style/values/grid/StyleGridNamedLinesMap.h:
* Source/WebCore/style/values/grid/StyleGridOrderedNamedLinesMap.h:
* Source/WebCore/style/values/grid/StyleGridPosition.cpp:
* Source/WebCore/style/values/grid/StyleGridPosition.h:
* Source/WebCore/style/values/grid/StyleGridTemplateList.cpp:
* Source/WebCore/style/values/grid/StyleGridTemplateList.h:
* Source/WebCore/style/values/grid/StyleGridTrackBreadth.cpp:
* Source/WebCore/style/values/grid/StyleGridTrackBreadth.h:
* Source/WebCore/style/values/grid/StyleGridTrackSize.cpp:
* Source/WebCore/style/values/grid/StyleGridTrackSize.h:
* Source/WebCore/style/values/grid/StyleGridTrackSizes.cpp:
* Source/WebCore/style/values/grid/StyleGridTrackSizes.h:
* Source/WebCore/style/values/primitives/StyleLengthWrapper.h:
* Tools/TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
Canonical link: https://commits.webkit.org/312882@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
