Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a5281fccbebd4996cf1b353bb93be06b8b4e9ce8
https://github.com/WebKit/WebKit/commit/a5281fccbebd4996cf1b353bb93be06b8b4e9ce8
Author: Alan Baradlay <[email protected]>
Date: 2026-05-10 (Sun, 10 May 2026)
Changed paths:
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/LocalFrameView.h
M Source/WebCore/rendering/RenderImage.cpp
M Source/WebCore/rendering/RenderImage.h
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderReplaced.h
M Source/WebCore/rendering/RenderWidget.cpp
M Source/WebCore/rendering/RenderWidget.h
M Source/WebCore/svg/graphics/SVGImage.cpp
M Source/WebCore/svg/graphics/SVGImage.h
Log Message:
-----------
Rename embeddedContentBox() to embeddedSVGRoot() and tighten return type to
RenderReplaced*
https://bugs.webkit.org/show_bug.cgi?id=314456
Reviewed by Antti Koivisto.
embeddedContentBox only ever returns the RenderSVGRoot or LegacyRenderSVGRoot
of an
embedded SVG document. Both always inherit from RenderReplaced, never just
RenderBox. The old name "embeddedContentBox" was vague and the RenderBox return
type hid this invariant, forcing callers to do unnecessary downcasts.
Now the name says what it is, the return type matches it, and callers work
directly with RenderReplaced without intermediate casts. The LocalFrameView
implementation simplifies to a single dynamicDowncast<RenderReplaced> since both
SVG root types satisfy that check.
Canonical link: https://commits.webkit.org/312970@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
