Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 746a64b3d246b28b974ccd757e638b61c76658cc
https://github.com/WebKit/WebKit/commit/746a64b3d246b28b974ccd757e638b61c76658cc
Author: Alan Baradlay <[email protected]>
Date: 2026-05-10 (Sun, 10 May 2026)
Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
Log Message:
-----------
Refactor computeSizingKeywordLogicalContentHeightUsingGeneric to consolidate
grid item stretch handling into a single branch
https://bugs.webkit.org/show_bug.cgi?id=314425
Reviewed by Antti Koivisto.
The stretch keyword handler had grid item checks scattered across three places
(!isGridItem() for percent-height registration, !isGridItem() for the
definiteness
check, and else-if isGridItem() for the available space computation). This made
the
code harder to follow.
Consolidate the grid path into a single early branch inside an availableSpace
lambda,
so grid items are fully handled in one place and the non-grid path reads
linearly
without negated guards.
No behavior change.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeSizingKeywordLogicalContentHeightUsingGeneric):
Canonical link: https://commits.webkit.org/312971@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
