Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 92b2fb9f20fd5f3d4f83f36c472915ccb11dc03f
https://github.com/WebKit/WebKit/commit/92b2fb9f20fd5f3d4f83f36c472915ccb11dc03f
Author: Antoine Quint <[email protected]>
Date: 2026-09-07 (Mon, 07 Sep 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-named-scroll-progress-timeline.tentative-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-none-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-dynamic.tentative-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-in-container-query-expected.txt
M Source/WebCore/animation/StyleOriginatedTimelinesController.cpp
Log Message:
-----------
[scroll-animations] WPT test
`scroll-animations/css/animation-timeline-none.html` has a failure
https://bugs.webkit.org/show_bug.cgi?id=323616
rdar://186856274
Reviewed by Simon Fraser.
More fallout from the spec change to make style-originated timelines match
globally [0].
We must make sure in `StyleOriginatedTimelinesController::attachAnimation()` to
always
yield an inactive style-originated timelines if we can't find the provided name
set by
the `animation-timeline` property regardless of whether we have an element with
a
`timeline-scope` property matching this name in the animation target's
hierarchy.
This change caused a regression in the 'A timline scope in the ancestor chain'
(sic)
test in `scroll-animations/css/timeline-scope.html` which prompted the change in
`StyleOriginatedTimelinesController::updateNamedTimelineMapForTimelineScope()`
to update the timeline relationship for any animation associated with a timeline
which has a name that was contained in a `timeline-scope` property newly set to
`none`.
Note that the regression in
`scroll-animations/css/scroll-timeline-in-container-query.html`
is only temporary, this test has yet to be updated for the spec change in
question [1].
[0] https://github.com/w3c/csswg-drafts/pull/13624
[1] https://github.com/web-platform-tests/wpt/pull/62200
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-named-scroll-progress-timeline.tentative-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-none-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-dynamic.tentative-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-in-container-query-expected.txt:
* Source/WebCore/animation/StyleOriginatedTimelinesController.cpp:
(WebCore::StyleOriginatedTimelinesController::attachAnimation):
(WebCore::StyleOriginatedTimelinesController::updateNamedTimelineMapForTimelineScope):
Canonical link: https://commits.webkit.org/320629@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
