Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fa7a14d6070a68460b7203f520a518b843114af0
https://github.com/WebKit/WebKit/commit/fa7a14d6070a68460b7203f520a518b843114af0
Author: Alan Baradlay <[email protected]>
Date: 2026-09-07 (Mon, 07 Sep 2026)
Changed paths:
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/rendering/RenderListItem.cpp
M Source/WebCore/rendering/RenderListOutsideMarker.cpp
M Source/WebCore/rendering/RenderListOutsideMarker.h
M Source/WebCore/rendering/RenderTreeAsText.cpp
Log Message:
-----------
[cleanup] Drop RenderListOutsideMarker::m_textContent, the marker box's copy
of text the list item already computes
https://bugs.webkit.org/show_bug.cgi?id=323547
rdar://problem/186792207
Reviewed by Antti Koivisto.
The marker box kept the text it shows in a member, which the renderers holding
that text have since become the
place for. Everything that read it goes through RenderListItem::markerText now,
which computes the same text
from style, and answers for the inline marker shape too. It grew the one rule
the member carried: a marker
showing an image says nothing. That rule was written out twice, so give it a
name.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::stitchGroups const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement const):
(WebCore::AccessibilityRenderObject::stringValue const):
(WebCore::AccessibilityRenderObject::listMarkerText const):
* Source/WebCore/rendering/RenderListItem.cpp:
(WebCore::RenderListItem::markerText const):
* Source/WebCore/rendering/RenderListOutsideMarker.cpp:
(WebCore::RenderListOutsideMarker::layoutContentContainer):
(WebCore::RenderListOutsideMarker::updateContent):
(WebCore::RenderListOutsideMarker::updateContentContainerText):
(WebCore::listMarkerShowsImage):
(WebCore::listMarkerSynthesizesGlyph):
(WebCore::RenderListOutsideMarker::textContent const): Deleted.
* Source/WebCore/rendering/RenderListOutsideMarker.h:
* Source/WebCore/rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::markerTextForListItem):
Canonical link: https://commits.webkit.org/320630@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
