Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 268a7c104514da6b0cffbe15b29677b01bb142d8
https://github.com/WebKit/WebKit/commit/268a7c104514da6b0cffbe15b29677b01bb142d8
Author: Fady Farag <[email protected]>
Date: 2026-09-08 (Tue, 08 Sep 2026)
Changed paths:
M Source/WebCore/SaferCPPExpectations/NoDeleteCheckerExpectations
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/page/EditorClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm
Log Message:
-----------
Pass `TextCheckingResult` by const reference so
`handleAcceptedCandidateWithSoftSpaces()` can be `NODELETE`
https://bugs.webkit.org/show_bug.cgi?id=323655
rdar://186903443
Reviewed by Chris Dumez.
Initially, `TextCheckingResult` was passed by value to
`EditorClient::handleAcceptedCandidateWithSoftSpaces()`
which triggered `NoDeleteChecker`'s parameter rule where it counts a by-value
parameter with a
non-trivially-destructible member against the callee. This now passes
`TextCheckingResult` by
const reference instead, since the struct owns a `Vector<GrammarDetail>` and a
`String` and no
override mutates it.
* Source/WebCore/SaferCPPExpectations/NoDeleteCheckerExpectations:
* Source/WebCore/loader/EmptyClients.cpp:
* Source/WebCore/page/EditorClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::handleAcceptedCandidateWithSoftSpaces):
Canonical link: https://commits.webkit.org/320693@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
