Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6156a0940859c71c1c3a9278024908aecf9760f7
https://github.com/WebKit/WebKit/commit/6156a0940859c71c1c3a9278024908aecf9760f7
Author: Sihui Liu <[email protected]>
Date: 2026-09-08 (Tue, 08 Sep 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
Log Message:
-----------
[Site Isolation] Remove process model validation in
SiteIsolation.MultiProcessBFCacheSameSiteWithDifferentCrossSiteIframes
https://bugs.webkit.org/show_bug.cgi?id=323700
rdar://186956421
Reviewed by Per Arne Vollan.
The test asserted the per-process frame tree topology via
checkFrameTreesInProcesses(), which reports one tree per web
process. That count is a property of the process model, not of the behavior the
test is about: with
SiteIsolationSharedProcessEnabled the b.com and c.com iframes are placed in the
same shared process, so the expected
three trees collapse into two and the test fails.
Nothing about the test's subject depends on where the frames live. It covers
same-site back/forward cache with a
cross-site iframe: a1 (a.com with a b.com iframe) is cached and replaced by a2
(a.com with a c.com iframe), and going
back must restore a1 together with its b.com iframe from the cache rather than
reloading them. Rewrite it to assert
exactly that, using JavaScript markers set in the main frame and in the iframe
before the navigation away — a reload
would produce a fresh global object without them, and reading the iframe-scope
marker round-trips to whichever process
hosts the iframe. Reattachment of the iframe subtree happens after the main
frame commits, so wait for the child frame
to become b.com again rather than assuming it is there when the navigation
finishes.
The test now passes with SiteIsolationSharedProcessEnabled both on and off,
without opting out of the shared process and
without a separate variant.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm:
(TestWebKitAPI::(SiteIsolation,
MultiProcessBFCacheSameSiteWithDifferentCrossSiteIframes)):
Canonical link: https://commits.webkit.org/320698@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
