Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 68fcd14affc42a3e5089a2bae7a61e94e442560d
https://github.com/WebKit/WebKit/commit/68fcd14affc42a3e5089a2bae7a61e94e442560d
Author: Anne van Kesteren <[email protected]>
Date: 2026-09-09 (Wed, 09 Sep 2026)
Changed paths:
M Source/WebCore/Scripts/GenerateSettings.rb
M Source/WebCore/page/Settings.yaml
Log Message:
-----------
Validate Settings.yaml and remove two settings defined twice
https://bugs.webkit.org/show_bug.cgi?id=323662
Reviewed by Chris Dumez.
PitchCorrectionAlgorithm and StorageBlockingPolicy were defined in both
UnifiedWebPreferences.yaml and Settings.yaml. Settings.yaml is read second, so
its definition replaced the other one and the WebCore default in the unified
file was never used. Both files gave the same value, so nothing was broken, but
editing the unified file would have had no effect. Remove the two entries from
Settings.yaml, and make defining a setting twice an error.
This changes seven lines of Settings.h and Settings.cpp. The unified file writes
these types with a WebCore:: prefix, which WebKit needs for its static_cast, so
the members are now WebCore::StorageBlockingPolicy and
WebCore::MediaPlayerEnums::PitchCorrectionAlgorithm. Both spellings name the
same types. I.e., no actual change.
GenerateSettings.rb now also does minimal validation for Settings.yaml.
Canonical link: https://commits.webkit.org/320718@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
