Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ea7eb77de6c1652f9da51316e2617f1fd2d77f89
https://github.com/WebKit/WebKit/commit/ea7eb77de6c1652f9da51316e2617f1fd2d77f89
Author: Diego Pino Garcia <[email protected]>
Date: 2026-09-09 (Wed, 09 Sep 2026)
Changed paths:
R LayoutTests/accessibility/gtk/text-for-range-combo-box-expected.txt
R LayoutTests/accessibility/gtk/text-for-range-combo-box.html
R LayoutTests/accessibility/gtk/text-for-range-embedded-objects-expected.txt
R LayoutTests/accessibility/gtk/text-for-range-embedded-objects.html
R
LayoutTests/accessibility/gtk/text-for-range-entry-and-password-expected.txt
R LayoutTests/accessibility/gtk/text-for-range-entry-and-password.html
R LayoutTests/accessibility/gtk/text-for-range-formatted-expected.txt
R LayoutTests/accessibility/gtk/text-for-range-formatted.html
R LayoutTests/accessibility/gtk/text-for-range-heading-expected.txt
R LayoutTests/accessibility/gtk/text-for-range-heading.html
R LayoutTests/accessibility/gtk/text-for-range-list-items-expected.txt
R LayoutTests/accessibility/gtk/text-for-range-list-items.html
R LayoutTests/accessibility/gtk/text-for-range-simple-expected.txt
R LayoutTests/accessibility/gtk/text-for-range-simple.html
R LayoutTests/accessibility/gtk/text-for-range-table-cells-expected.txt
R LayoutTests/accessibility/gtk/text-for-range-table-cells.html
R LayoutTests/accessibility/gtk/text-for-range-with-link-expected.txt
R LayoutTests/accessibility/gtk/text-for-range-with-link.html
R LayoutTests/accessibility/gtk/text-for-table-expected.txt
R LayoutTests/accessibility/gtk/text-for-table.html
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/gtk/TestWebKitAccessibility.cpp
M Tools/TestWebKitAPI/glib/TestExpectations.json
Log Message:
-----------
REGRESSION(r274919): Convert GTK A11y text-for-range layout tests to API tests
https://bugs.webkit.org/show_bug.cgi?id=223862
Reviewed by Carlos Garcia Campos.
Several A11y tests have been failing since r274919. These tests use
'stringForRange(0, -1)' to retrieve the full text content of an
accessible object. However, since that changeset the test runner no
longer accepts '-1' as a valid offset, returning an empty string which
makes those tests fail.
This change rewrites the functionality covered in 'text-for-range'
layout tests to API tests, where test behavior is implemented directly
using the API.
Tested on a GTK3 build, since at this moment A11y API tests are failing
on GTK4 (See: webkit.org/b/279009).
* LayoutTests/accessibility/gtk/text-for-range-combo-box-expected.txt: Removed.
* LayoutTests/accessibility/gtk/text-for-range-combo-box.html: Removed.
* LayoutTests/accessibility/gtk/text-for-range-embedded-objects-expected.txt:
Removed.
* LayoutTests/accessibility/gtk/text-for-range-embedded-objects.html: Removed.
* LayoutTests/accessibility/gtk/text-for-range-entry-and-password-expected.txt:
Removed.
* LayoutTests/accessibility/gtk/text-for-range-entry-and-password.html: Removed.
* LayoutTests/accessibility/gtk/text-for-range-formatted-expected.txt: Removed.
* LayoutTests/accessibility/gtk/text-for-range-formatted.html: Removed.
* LayoutTests/accessibility/gtk/text-for-range-heading-expected.txt: Removed.
* LayoutTests/accessibility/gtk/text-for-range-heading.html: Removed.
* LayoutTests/accessibility/gtk/text-for-range-list-items-expected.txt: Removed.
* LayoutTests/accessibility/gtk/text-for-range-list-items.html: Removed.
* LayoutTests/accessibility/gtk/text-for-range-simple-expected.txt: Removed.
* LayoutTests/accessibility/gtk/text-for-range-simple.html: Removed.
* LayoutTests/accessibility/gtk/text-for-range-table-cells-expected.txt:
Removed.
* LayoutTests/accessibility/gtk/text-for-range-table-cells.html: Removed.
* LayoutTests/accessibility/gtk/text-for-range-with-link-expected.txt: Removed.
* LayoutTests/accessibility/gtk/text-for-range-with-link.html: Removed.
* LayoutTests/accessibility/gtk/text-for-table-expected.txt: Removed.
* LayoutTests/accessibility/gtk/text-for-table.html: Removed.
* LayoutTests/platform/gtk/TestExpectations:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/gtk/TestWebKitAccessibility.cpp:
(testTextReplacedObjects):
(testTextForRangeSimple):
(testTextForRangeEmbeddedObjects):
(testTextForRangeHeading):
(testTextForRangeListItem):
(testTextForRangeTableCell):
(beforeAll):
Canonical link: https://commits.webkit.org/320721@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
