Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 31875dc6237b81e4faf20e0a83f968ba10f062c7
https://github.com/WebKit/WebKit/commit/31875dc6237b81e4faf20e0a83f968ba10f062c7
Author: Jean-Yves Avenard <[email protected]>
Date: 2026-09-24 (Thu, 24 Sep 2026)
Changed paths:
M Tools/Scripts/webkitdirs.pm
Log Message:
-----------
[cmake] build-webkit removes the CMake cache even when the configuration did
not change
https://bugs.webkit.org/show_bug.cgi?id=324650
rdar://187896942
Reviewed by Elliott Williams.
build-webkit keeps a key in build-webkit-options.txt, in the product directory.
When the key changes, build-webkit deletes the CMake cache. An argument that is
not given is taken from the recorded settings, so it is the same as the one the
last build used. The key did not say that: it held the arguments that were
explicitly typed.
So one build wrote one key when the arguments were given, and another key when
they were left out, and the cache went away.
The key now leaves out the arguments that only pick the configuration or the
build system. Each of them names the product directory, and the key file is in
that directory, so a different value is a different file. On Cocoa with cmake a
sanitizer and a forced optimization level name the directory as well, and they
are left out there too.
* Tools/Scripts/webkitdirs.pm:
(shouldRemoveCMakeCache): Ignore the arguments that only pick the configuration.
Canonical link: https://commits.webkit.org/321869@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
