Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 06b97ce133b3c664f0ffc9f0cd4a331672cc7390
https://github.com/WebKit/WebKit/commit/06b97ce133b3c664f0ffc9f0cd4a331672cc7390
Author: Cole Carley <[email protected]>
Date: 2026-09-25 (Fri, 25 Sep 2026)
Changed paths:
M LayoutTests/fast/quirks/active-quirks-by-domain-expected.txt
M LayoutTests/platform/glib/fast/quirks/active-quirks-by-domain-expected.txt
M LayoutTests/platform/ios/fast/quirks/active-quirks-by-domain-expected.txt
M LayoutTests/platform/ipad/fast/quirks/active-quirks-by-domain-expected.txt
M
LayoutTests/platform/mac-sequoia/fast/quirks/active-quirks-by-domain-expected.txt
M
LayoutTests/platform/mac-tahoe/fast/quirks/active-quirks-by-domain-expected.txt
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/page/QuirkBehaviors.h
A Source/WebCore/page/QuirkSelectors.h
M Source/WebCore/page/QuirkTable.cpp
M Source/WebCore/page/Quirks.cpp
M Tools/TestWebKitAPI/Tests/WebCore/Quirks.cpp
Log Message:
-----------
[Quirks] Remove GoogleDocs, GoogleSearch and TikTok quirk sites
https://bugs.webkit.org/show_bug.cgi?id=325184
rdar://188319874
Reviewed by Brent Fulgham.
There are a number of Quirks that are still using QuirkSite. These quirks should
migrate to the new data driven QuirkTable instead.
This patch moves a handful of Quirks into the Quirk table. I also moved all the
Quirk element selectors in a new QuirkSelectors.h under a QuirkSelectors
namespace,
so the selectors could be reused in unit tests instead of duplicated.
Test: Tools/TestWebKitAPI/Tests/WebCore/Quirks.cpp
* LayoutTests/fast/quirks/active-quirks-by-domain-expected.txt:
* LayoutTests/platform/glib/fast/quirks/active-quirks-by-domain-expected.txt:
* LayoutTests/platform/ios/fast/quirks/active-quirks-by-domain-expected.txt:
* LayoutTests/platform/ipad/fast/quirks/active-quirks-by-domain-expected.txt:
*
LayoutTests/platform/mac-sequoia/fast/quirks/active-quirks-by-domain-expected.txt:
*
LayoutTests/platform/mac-tahoe/fast/quirks/active-quirks-by-domain-expected.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/page/QuirkBehaviors.h:
* Source/WebCore/page/QuirkSelectors.h: Added.
* Source/WebCore/page/QuirkTable.cpp:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsAnchorToBeMouseFocusable const):
(WebCore::Quirks::shouldPreventDispatchOfTouchEvent const):
(WebCore::Quirks::shouldOpenAsAboutBlank const):
(WebCore::Quirks::needsClaudeSidebarViewportUnitQuirk const):
(WebCore::Quirks::needsTikTokOverflowingContentQuirk const):
(WebCore::Quirks::needsInstagramResizingReelsQuirk const):
* Tools/TestWebKitAPI/Tests/WebCore/Quirks.cpp:
(TestWebKitAPI::TEST_F(QuirksTest,
OnlyGoogleSearchLimitsMouseFocusableAnchorsToTheExpandablePanel)):
(TestWebKitAPI::TEST_F(QuirksTest,
ExpandablePanelSelectorMatchesThePanelAndAnythingInsideIt)):
(TestWebKitAPI::TEST_F(QuirksTest,
ClaudeSidebarQuirkCarriesTheSidebarSelector)):
(TestWebKitAPI::TEST_F(QuirksTest, OnlyGoogleDocsOpensAboutURLsAsAboutBlank)):
(TestWebKitAPI::TEST_F(QuirksTest,
ClaudeSidebarSelectorMatchesTheAriaLabelExactly)):
(TestWebKitAPI::TEST_F(QuirksTest,
TikTokCarriesSeparateSelectorsForTheCommentsAndVideoContainers)):
(TestWebKitAPI::TEST_F(QuirksTest,
TikTokSelectorsMatchClassNameSubstringsUnderTheBrowserModeContainer)):
(TestWebKitAPI::TEST_F(QuirksTest,
EachSiteThatPreventsTouchDispatchCarriesOnlyItsOwnSelector)):
(TestWebKitAPI::TEST_F(QuirksTest,
TouchDispatchSelectorsRequireEveryClassInThePair)):
(TestWebKitAPI::TEST_F(QuirksTest,
InstagramReelsQuirkOnlyAppliesToElementsContainingAVideo)):
(TestWebKitAPI::reelWidthsForTopURL):
(TestWebKitAPI::TEST_F(QuirksTest,
InstagramReelsGrowToFillTheirFlexContainerOnlyWhenTheyContainAVideo)):
Canonical link: https://commits.webkit.org/321913@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
