Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ce956f331d7641190768966c59ad993eca9dc0f5
https://github.com/WebKit/WebKit/commit/ce956f331d7641190768966c59ad993eca9dc0f5
Author: Brady Eidson <[email protected]>
Date: 2026-09-25 (Fri, 25 Sep 2026)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
M Tools/TestWebKitAPI/SourcesCocoa.txt
A Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
Log Message:
-----------
[Site Isolation] Editing, font, and spelling commands don't work in focused
cross-origin iframes
rdar://188420470
https://bugs.webkit.org/show_bug.cgi?id=325308
Reviewed by Ryosuke Niwa.
Route a whole bunch of `send` to `focusedOrMainFrame` processes, instead.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::restoreSelectionInFocusedEditableElement):
(WebKit::WebPageProxy::validateCommand):
(WebKit::WebPageProxy::increaseListLevel):
(WebKit::WebPageProxy::decreaseListLevel):
(WebKit::WebPageProxy::changeListType):
(WebKit::WebPageProxy::setBaseWritingDirection):
(WebKit::WebPageProxy::requestFontAttributesAtSelectionStart):
(WebKit::WebPageProxy::centerSelectionInVisibleArea):
(WebKit::WebPageProxy::getSelectionOrContentsAsString):
(WebKit::WebPageProxy::advanceToNextMisspelling):
(WebKit::WebPageProxy::changeSpellingToWord):
(WebKit::WebPageProxy::focusedFrameChanged):
(WebKit::WebPageProxy::handleAlternativeTextUIResult):
(WebKit::WebPageProxy::changeFontAttributes):
(WebKit::WebPageProxy::changeFont):
(WebKit::WebPageProxy::closeCurrentTypingCommand):
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::generateSyntheticEditingCommand):
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::attributedSubstringForCharacterRangeAsync):
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm: Added.
(-[SiteIsolationUnderlineAttributeConverter convertAttributes:]):
(TestWebKitAPI::webViewWithFocusedCrossOriginIframe):
(TestWebKitAPI::setSelectionInFrame):
(TestWebKitAPI::TEST(SiteIsolation, ListCommandsInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation, ValidateMenuItemInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation, ChangeFontAttributesInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation, TypingAttributesInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation, AttributedSubstringInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation, ChangeSpellingInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation, CheckSpellingInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation,
CenterSelectionInVisibleAreaInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation, BaseWritingDirectionInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation, ChangeFontSizeInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation, SpeakSelectionInCrossOriginIframe)):
Canonical link: https://commits.webkit.org/321953@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
