Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 868ef79407512ac3a0152a2c9c09565530c071e6
      
https://github.com/WebKit/WebKit/commit/868ef79407512ac3a0152a2c9c09565530c071e6
  Author: Dan Hecht <[email protected]>
  Date:   2026-09-27 (Sun, 27 Sep 2026)

  Changed paths:
    M Source/JavaScriptCore/heap/ConservativeRoots.cpp
    M Source/JavaScriptCore/heap/Heap.cpp
    M Source/JavaScriptCore/heap/Heap.h
    M Source/JavaScriptCore/wasm/WasmCalleeGroup.cpp

  Log Message:
  -----------
  [JSC] Name the Wasm callee cleanup Heap functions for the marking they do
https://bugs.webkit.org/show_bug.cgi?id=325327
rdar://188435875

Reviewed by Yusuke Suzuki and Mark Lam.

These functions implement a mark phase for Wasm callees, but their names hid 
it: "prepare"
and "finalize" a "cleanup" obscured that marking decides which callees survive, 
and
didDiscoverPendingWasmCallee read like a notification rather than the mark 
itself. Name
them for marking.

No change in behavior.

* Source/JavaScriptCore/heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::genericAddPointer):
* Source/JavaScriptCore/heap/Heap.cpp:
(JSC::Heap::beginMarking):
(JSC::Heap::endMarking):
(JSC::Heap::clearConcurrentRetainedDataIfPossible):
* Source/JavaScriptCore/heap/Heap.h:
* Source/JavaScriptCore/wasm/WasmCalleeGroup.cpp:
(JSC::Wasm::CalleeGroup::CallerCallsiteFlushes::flush):

Canonical link: https://commits.webkit.org/322008@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to