Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f4bdbd8da76120c087250fd09b45e34c147889eb
https://github.com/WebKit/WebKit/commit/f4bdbd8da76120c087250fd09b45e34c147889eb
Author: Brady Eidson <[email protected]>
Date: 2026-09-27 (Sun, 27 Sep 2026)
Changed paths:
M Source/WebKit/UIProcess/API/APIAttachment.cpp
M Source/WebKit/UIProcess/API/APIAttachment.h
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Tools/TestWebKitAPI/Helpers/cocoa/SiteIsolationTestUtilities.h
M Tools/TestWebKitAPI/Helpers/cocoa/SiteIsolationTestUtilities.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
Log Message:
-----------
[Site Isolation] Attachments in cross-origin iframes can't be inserted or
updated, and never get their icons
rdar://188490796
https://bugs.webkit.org/show_bug.cgi?id=325382
Reviewed by Anne van Kesteren.
Route these messages to the appropriate processes!
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
* Source/WebKit/UIProcess/API/APIAttachment.cpp:
(API::Attachment::owningProcess const):
(API::Attachment::setOwningProcess):
* Source/WebKit/UIProcess/API/APIAttachment.h:
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::updateIconForDirectory):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestAttachmentIcon):
(WebKit::WebPageProxy::insertAttachment):
(WebKit::WebPageProxy::updateAttachmentAttributes):
(WebKit::WebPageProxy::didInsertAttachmentWithIdentifier):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::attachmentElementWithIdentifier const):
* Tools/TestWebKitAPI/Helpers/cocoa/SiteIsolationTestUtilities.h:
* Tools/TestWebKitAPI/Helpers/cocoa/SiteIsolationTestUtilities.mm:
(TestWebKitAPI::webViewWithFocusedCrossOriginIframe):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm:
(-[SiteIsolationAttachmentObserver init]):
(-[SiteIsolationAttachmentObserver _webView:didInsertAttachment:withSource:]):
(-[SiteIsolationAttachmentObserver insertedAttachments]):
(TestWebKitAPI::attachmentEnabledConfiguration):
(TestWebKitAPI::textFileWrapper):
(TestWebKitAPI::TEST(SiteIsolation, InsertAttachmentInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation,
SetFileWrapperForAttachmentInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation, AttachmentIconInCrossOriginIframe)):
Canonical link: https://commits.webkit.org/322010@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
