Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 495909dc15a77e79105c80a63d986151c0c7a12b
https://github.com/WebKit/WebKit/commit/495909dc15a77e79105c80a63d986151c0c7a12b
Author: Charlie Wolfe <[email protected]>
Date: 2026-09-29 (Tue, 29 Sep 2026)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt
M LayoutTests/platform/mac/TestExpectations
M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/mac/RenderThemeMac.mm
Log Message:
-----------
[macOS] Map deprecated CSS system colors to their CSS Color 4 equivalents
https://bugs.webkit.org/show_bug.cgi?id=325250
rdar://188365953
Reviewed by Aditya Keerthi.
CSS Color 4 says deprecated system colors (ActiveBorder, Menu, Scrollbar,
ThreeDFace, Window, etc)
must compute to the same value as a non-deprecated system color. RenderThemeMac
overrode most of
them with arbitrary NSColors, which broke that rule. Remove those overrides so
the spec mappings in
RenderTheme::systemColor() apply. This also removes menuBackgroundColor(),
which used the deprecated
NSDrawMenuBackground().
Also fix ActiveCaption, which the base class mapped to CanvasText. The spec
maps it to Canvas.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt:
* LayoutTests/platform/mac/TestExpectations:
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::systemColor const):
* Source/WebCore/rendering/mac/RenderThemeMac.mm:
(WebCore::usesLegacyDeprecatedSystemColors):
(WebCore::legacyMenuBackgroundColor):
(WebCore::legacyDeprecatedSystemColor):
(WebCore::RenderThemeMac::systemColor const):
(WebCore::menuBackgroundColor): Deleted.
Canonical link: https://commits.webkit.org/322193@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
