Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 24064bba1041c55e10f9b6da1d64b3cddeae61e3
https://github.com/WebKit/WebKit/commit/24064bba1041c55e10f9b6da1d64b3cddeae61e3
Author: Chris Dumez <[email protected]>
Date: 2026-09-30 (Wed, 30 Sep 2026)
Changed paths:
M Source/WebCore/css/values/CSSValueAggregates.h
M Tools/TestWebKitAPI/CMakeLists.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WebCore/CSSValueAggregates.cpp
Log Message:
-----------
anyOf() on two-value CSS aggregates returns allOf() result
https://bugs.webkit.org/show_bug.cgi?id=325758
Reviewed by Sam Weinig.
MinimallySerializingSpaceSeparatedPair, SpaceSeparatedPoint, SpaceSeparatedSize,
MinimallySerializingSpaceSeparatedPoint and
MinimallySerializingSpaceSeparatedSize
implemented anyOf() by forwarding to allOf() on their underlying pair, so it
only
returned true when every value matched.
This is not web-exposed, so it cannot be covered by a layout test: every current
anyOf() caller operates on RectEdges, RectCorners or the *RectEdges aggregates,
which implement anyOf() correctly. The closest case,
BorderData::hasBorderRadius(),
holds MinimallySerializingSpaceSeparatedSize corners but calls anyOf() on the
enclosing RectCorners. An API test exercises the affected types directly
instead.
Test: Tools/TestWebKitAPI/Tests/WebCore/CSSValueAggregates.cpp
* Source/WebCore/css/values/CSSValueAggregates.h:
(WebCore::MinimallySerializingSpaceSeparatedPair::anyOf const):
(WebCore::SpaceSeparatedPoint::anyOf const):
(WebCore::SpaceSeparatedSize::anyOf const):
(WebCore::MinimallySerializingSpaceSeparatedPoint::anyOf const):
(WebCore::MinimallySerializingSpaceSeparatedSize::anyOf const):
* Tools/TestWebKitAPI/CMakeLists.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebCore/CSSValueAggregates.cpp: Added.
(TestWebKitAPI::testAnyOfAllOf):
(TestWebKitAPI::TEST(CSSValueAggregates, SpaceSeparatedPairAnyOf)):
(TestWebKitAPI::TEST(CSSValueAggregates,
MinimallySerializingSpaceSeparatedPairAnyOf)):
(TestWebKitAPI::TEST(CSSValueAggregates, SpaceSeparatedPointAnyOf)):
(TestWebKitAPI::TEST(CSSValueAggregates, SpaceSeparatedSizeAnyOf)):
(TestWebKitAPI::TEST(CSSValueAggregates,
MinimallySerializingSpaceSeparatedPointAnyOf)):
(TestWebKitAPI::TEST(CSSValueAggregates,
MinimallySerializingSpaceSeparatedSizeAnyOf)):
Canonical link: https://commits.webkit.org/322326@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
