Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 079c1e32aee1fcc1b1d7e16ca05d3bd15de277d8
https://github.com/WebKit/WebKit/commit/079c1e32aee1fcc1b1d7e16ca05d3bd15de277d8
Author: Andy Estes <[email protected]>
Date: 2026-09-30 (Wed, 30 Sep 2026)
Changed paths:
M Source/WebCore/dom/Document.cpp
M Source/WebCore/page/ChromeClient.h
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
Log Message:
-----------
[Site Isolation] Remove usage of `convertRectToMainFrameCoordinates` in
`WebPageProxy::showPlaybackTargetPicker`
https://bugs.webkit.org/show_bug.cgi?id=325000
rdar://188207610
Reviewed by Tim Nguyen and Megan Gardner.
Removed usage of convertRectToMainFrameCoordinates in
WebPageProxy::showPlaybackTargetPicker and
used contentsToMainFrameView instead. Added API tests verifying that the
AirPlay target picker is
positioned correctly in scrolled main frames and subframes.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::showPlaybackTargetPicker):
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::showPlaybackTargetPicker):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::showPlaybackTargetPicker):
* Source/WebCore/page/Page.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPlaybackTargetPicker):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::showPlaybackTargetPicker):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::showPlaybackTargetPicker):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm:
(TestWebKitAPI::(SiteIsolation, AirPlayPickerLocationInCrossSiteIframe)):
(TestWebKitAPI::(SiteIsolation,
AirPlayPickerLocationInScrolledCrossSiteIframe)):
(TestWebKitAPI::(SiteIsolation,
AirPlayPickerLocationInCrossSiteIframeWithScrolledMainFrame)):
(TestWebKitAPI::(SiteIsolation,
AirPlayPickerLocationInScrolledCrossSiteIframeWithScrolledMainFrame)):
Canonical link: https://commits.webkit.org/322343@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
