Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 59e60dcd811426871a3c935766541cac10620078
https://github.com/WebKit/WebKit/commit/59e60dcd811426871a3c935766541cac10620078
Author: Alan Baradlay <[email protected]>
Date: 2026-09-30 (Wed, 30 Sep 2026)
Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayBox.h
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M Source/WebCore/layout/integration/inline/InlineIteratorInlineBox.cpp
Log Message:
-----------
[IFC] Inline box borders should close where layout says the inline box starts
and ends
https://bugs.webkit.org/show_bug.cgi?id=325366
<rdar://problem/188471367>
Reviewed by Elika Etemad.
<div style="line-clamp: 3">Line 1<br>Line 2<br><span style="border: 2px
solid">Line 3<br>Line 4</span></div>
The span continues after the clamp point, so its fragment on line 3 must not
have an end border.
closedEdges() decided the edges by looking for the next display box of the same
inline box, and there is
none after the clamp point. Layout already knows which fragment has the
start/end of the inline box,
so let's carry that on the display box and use it instead.
* LayoutTests/TestExpectations:
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayBox.h:
(WebCore::InlineDisplay::Box::isFirstFragment const):
(WebCore::InlineDisplay::Box::isLastFragment const):
(WebCore::InlineDisplay::Box::Box):
(WebCore::InlineDisplay::Box::setIsFirstLastFragment):
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):
* Source/WebCore/layout/integration/inline/InlineIteratorInlineBox.cpp:
(WebCore::InlineIterator::InlineBox::closedEdges const):
Canonical link: https://commits.webkit.org/322345@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
