Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e30b9e95be4a449c6195d780edb64576c9a303ae
https://github.com/WebKit/WebKit/commit/e30b9e95be4a449c6195d780edb64576c9a303ae
Author: Antti Koivisto <[email protected]>
Date: 2026-10-12 (Mon, 12 Oct 2026)
Changed paths:
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/css/scripts/process-css-properties.py
M
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/UsedStyleProperties.h
M Source/WebCore/rendering/BackgroundPainter.cpp
M Source/WebCore/rendering/BorderPainter.cpp
M Source/WebCore/rendering/BorderPainter.h
M Source/WebCore/rendering/InlineBoxPainter.cpp
M Source/WebCore/rendering/InlineBoxPainter.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderElementInlines.h
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTableCell.cpp
M Source/WebCore/rendering/style/UsedStyle.cpp
M Source/WebCore/rendering/style/UsedStyle.h
Log Message:
-----------
[UsedStyle] Add first-line UsedStyle
https://bugs.webkit.org/show_bug.cgi?id=327225
rdar://189792048
Reviewed by Alan Baradlay.
Used values for a non-box pseudo-element like ::first-line combine the host
renderer with the
pseudo-element style. Let UsedStyle wrap a renderer together with one of its
own pseudo-element
styles, and add RenderElement::firstLineUsedStyle() for ::first-line. Only
RenderElement can create
such a view, so the style always belongs to the renderer.
BorderPainter::paintBorder() takes a UsedStyle, with first-line inline boxes
passing the first-line
view. This prepares for moving the used border widths to UsedStyle. No behavior
change.
* Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations:
The style reference from UsedStyle::computedStyle() is now a member, which
fixes MathOperator.cpp.
* Source/WebCore/css/scripts/process-css-properties.py:
*
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/UsedStyleProperties.h:
(WebCore::UsedStyleProperties::UsedStyleProperties):
UsedStyleProperties holds the style next to the renderer.
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderElementInlines.h:
(WebCore::RenderElement::firstLineUsedStyle const):
* Source/WebCore/rendering/style/UsedStyle.cpp:
(WebCore::UsedStyle::UsedStyle):
* Source/WebCore/rendering/style/UsedStyle.h:
The constructor taking a pseudo-element style is private to RenderElement.
* Source/WebCore/rendering/BorderPainter.cpp:
(WebCore::BorderPainter::paintBorder const):
* Source/WebCore/rendering/BorderPainter.h:
* Source/WebCore/rendering/InlineBoxPainter.cpp:
(WebCore::InlineBoxPainter::paintDecorations):
(WebCore::InlineBoxPainter::usedStyle const):
* Source/WebCore/rendering/InlineBoxPainter.h:
* Source/WebCore/rendering/BackgroundPainter.cpp:
(WebCore::BackgroundPainter::paintFillLayerImpl const):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations):
* Source/WebCore/rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBoxDecorations):
Canonical link: https://commits.webkit.org/323463@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
