Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b67f5595d14e62f874fd640cdbac35bed8731cce
https://github.com/WebKit/WebKit/commit/b67f5595d14e62f874fd640cdbac35bed8731cce
Author: Chris Dumez <[email protected]>
Date: 2026-10-14 (Wed, 14 Oct 2026)
Changed paths:
M
Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/rendering/mathml/MathMLStyle.cpp
M Source/WebCore/rendering/mathml/MathMLStyle.h
M Source/WebCore/rendering/mathml/MathOperator.cpp
M Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp
M Source/WebCore/rendering/mathml/RenderMathMLBlock.h
M Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp
M Source/WebCore/rendering/mathml/RenderMathMLFencedOperator.cpp
M Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp
M Source/WebCore/rendering/mathml/RenderMathMLFraction.h
M Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp
M Source/WebCore/rendering/mathml/RenderMathMLMenclose.h
M Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp
M Source/WebCore/rendering/mathml/RenderMathMLOperator.h
M Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp
M Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp
M Source/WebCore/rendering/mathml/RenderMathMLRow.cpp
M Source/WebCore/rendering/mathml/RenderMathMLRow.h
M Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp
M Source/WebCore/rendering/mathml/RenderMathMLScripts.h
M Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp
M Source/WebCore/rendering/mathml/RenderMathMLToken.cpp
M Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp
Log Message:
-----------
[Safer CPP] Address warnings in rendering/mathml
https://bugs.webkit.org/show_bug.cgi?id=327355
Reviewed by Geoffrey Garen.
Address the safer-cpp static analysis warnings in rendering/mathml/. MathML
does not affect Speedometer or MotionMark, so the extra smart pointer use
has no performance impact on those benchmarks.
unembellishedOperator(), toVerticalStretchyOperator(),
horizontalStretchyOperator()
and MathMLStyle::getMathMLParentNode() now return a CheckedPtr.
* Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/rendering/mathml/MathMLStyle.cpp:
(WebCore::MathMLStyle::resolveMathMLStyleTree):
(WebCore::MathMLStyle::getMathMLParentNode):
(WebCore::MathMLStyle::resolveMathMLStyle):
* Source/WebCore/rendering/mathml/MathMLStyle.h:
* Source/WebCore/rendering/mathml/MathOperator.cpp:
(WebCore::MathOperator::getGlyph const):
(WebCore::MathOperator::getBaseGlyph):
(WebCore::glyphDataForCodePointOrFallbackGlyph):
(WebCore::MathOperator::getMathVariantsWithFallback):
(WebCore::MathOperator::calculateDisplayStyleLargeOperator):
* Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::unembellishedOperator const):
(WebCore::axisHeight):
(WebCore::RenderMathMLBlock::mathAxisHeight const):
(WebCore::RenderMathMLTable::firstLineBaseline const):
(WebCore::RenderMathMLBlock::layoutItems):
(WebCore::RenderMathMLBlock::computeAndSetBlockDirectionMarginsOfChildren):
(WebCore::RenderMathMLBlock::insertPositionedChildrenIntoContainingBlock):
(WebCore::RenderMathMLBlock::layoutFloatingChildren):
(WebCore::RenderMathMLBlock::sizeAppliedToMathContent):
* Source/WebCore/rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLBlock::unembellishedOperator const): Deleted.
* Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):
* Source/WebCore/rendering/mathml/RenderMathMLFencedOperator.cpp:
(WebCore::RenderMathMLFencedOperator::leadingSpace const):
(WebCore::RenderMathMLFencedOperator::trailingSpace const):
* Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::defaultLineThickness const):
(WebCore::RenderMathMLFraction::lineThickness const):
(WebCore::RenderMathMLFraction::fractionParameters const):
(WebCore::RenderMathMLFraction::stackParameters const):
(WebCore::RenderMathMLFraction::unembellishedOperator const):
(WebCore::RenderMathMLFraction::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLFraction::fractionAscent const):
(WebCore::RenderMathMLFraction::layoutBlock):
(WebCore::RenderMathMLFraction::paint):
* Source/WebCore/rendering/mathml/RenderMathMLFraction.h:
* Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp:
(WebCore::RenderMathMLMenclose::paint):
* Source/WebCore/rendering/mathml/RenderMathMLMenclose.h:
* Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::leadingSpace const):
(WebCore::RenderMathMLOperator::trailingSpace const):
(WebCore::RenderMathMLOperator::minSize const):
(WebCore::RenderMathMLOperator::maxSize const):
(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLOperator::updateMathOperator):
(WebCore::RenderMathMLOperator::styleDidChange):
* Source/WebCore/rendering/mathml/RenderMathMLOperator.h:
* Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp:
(WebCore::RenderMathMLPadded::voffset const):
(WebCore::RenderMathMLPadded::lspace const):
(WebCore::RenderMathMLPadded::mpaddedWidth const):
(WebCore::RenderMathMLPadded::mpaddedHeight const):
(WebCore::RenderMathMLPadded::mpaddedDepth const):
* Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::RenderMathMLRoot):
(WebCore::RenderMathMLRoot::horizontalParameters):
(WebCore::RenderMathMLRoot::verticalParameters const):
(WebCore::RenderMathMLRoot::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLRoot::layoutBlock):
(WebCore::RenderMathMLRoot::paint):
* Source/WebCore/rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::unembellishedOperator const):
(WebCore::RenderMathMLRow::firstLineBaseline const):
(WebCore::toVerticalStretchyOperator):
(WebCore::RenderMathMLRow::stretchVerticalOperatorsAndLayoutChildren):
(WebCore::RenderMathMLRow::getContentBoundingBox const):
(WebCore::RenderMathMLRow::preferredLogicalWidthOfRowItems):
(WebCore::RenderMathMLRow::layoutRowItems):
* Source/WebCore/rendering/mathml/RenderMathMLRow.h:
* Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::unembellishedOperator const):
(WebCore::RenderMathMLScripts::validateAndGetReferenceChildren const):
(WebCore::RenderMathMLScripts::spaceAfterScript):
(WebCore::RenderMathMLScripts::italicCorrection):
(WebCore::RenderMathMLScripts::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLScripts::verticalParameters const):
(WebCore::RenderMathMLScripts::verticalMetrics):
(WebCore::RenderMathMLScripts::layoutBlock):
* Source/WebCore/rendering/mathml/RenderMathMLScripts.h:
* Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:
(WebCore::RenderMathMLSpace::spaceWidth const):
(WebCore::RenderMathMLSpace::getSpaceHeightAndDepth const):
* Source/WebCore/rendering/mathml/RenderMathMLToken.cpp:
(WebCore::RenderMathMLToken::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLToken::firstLineBaseline const):
(WebCore::RenderMathMLToken::layoutBlock):
(WebCore::RenderMathMLToken::paint):
(WebCore::RenderMathMLToken::paintChildren):
* Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::horizontalStretchyOperator):
(WebCore::RenderMathMLUnderOver::stretchHorizontalOperatorsAndLayoutChildren):
(WebCore::RenderMathMLUnderOver::shouldMoveLimits const):
(WebCore::RenderMathMLUnderOver::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLUnderOver::hasAccent const):
(WebCore::RenderMathMLUnderOver::verticalParameters const):
(WebCore::RenderMathMLUnderOver::layoutBlock):
Canonical link: https://commits.webkit.org/323700@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
