Title: [118403] trunk/Source/WebKit/blackberry
Revision
118403
Author
mifen...@rim.com
Date
2012-05-24 12:29:19 -0700 (Thu, 24 May 2012)

Log Message

[BlackBerry] Padding adjustment for determining the relative distance for a point was backwards.
https://bugs.webkit.org/show_bug.cgi?id=87404

Reviewed by Rob Buis.

Fix padding calculation for handle adjustment.

Reviewed Internally by Mike Lattanzio.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::directionOfPointRelativeToRect):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (118402 => 118403)


--- trunk/Source/WebKit/blackberry/ChangeLog	2012-05-24 19:27:36 UTC (rev 118402)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-05-24 19:29:19 UTC (rev 118403)
@@ -1,5 +1,19 @@
 2012-05-24  Mike Fenton  <mifen...@rim.com>
 
+        [BlackBerry] Padding adjustment for determining the relative distance for a point was backwards.
+        https://bugs.webkit.org/show_bug.cgi?id=87404
+
+        Reviewed by Rob Buis.
+
+        Fix padding calculation for handle adjustment.
+
+        Reviewed Internally by Mike Lattanzio.
+
+        * WebKitSupport/SelectionHandler.cpp:
+        (BlackBerry::WebKit::directionOfPointRelativeToRect):
+
+2012-05-24  Mike Fenton  <mifen...@rim.com>
+
         [BlackBerry] Remove unused API function touchEventCancelAndClearFocusedNode.
         https://bugs.webkit.org/show_bug.cgi?id=87379
 

Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (118402 => 118403)


--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp	2012-05-24 19:27:36 UTC (rev 118402)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp	2012-05-24 19:29:19 UTC (rev 118403)
@@ -177,7 +177,7 @@
 
     // Do height movement check first but add padding. We may be off on both x & y axis and only
     // want to move in one direction at a time.
-    if (point.y() + (useTopPadding ? verticalPadding : 0) < rect.y())
+    if (point.y() - (useTopPadding ? verticalPadding : 0) < rect.y())
         return KEYCODE_UP;
     if (point.y() > rect.maxY() + (useBottomPadding ? verticalPadding : 0))
         return KEYCODE_DOWN;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to