Title: [118404] trunk
- Revision
- 118404
- Author
- commit-qu...@webkit.org
- Date
- 2012-05-24 12:38:10 -0700 (Thu, 24 May 2012)
Log Message
[EFL] [DRT] keyboard-related tests do not pass
https://bugs.webkit.org/show_bug.cgi?id=85369
Patch by Mikhail Pozdnyakov <mikhail.pozdnya...@intel.com> on 2012-05-24
Reviewed by Gustavo Noronha Silva.
Tools:
Add SHIFT modifier for capital letters as VK_
codes do not distinguish between lows and caps and also to be consistent
with other ports which send caps as lowercase letters with the shift key down.
* DumpRenderTree/efl/EventSender.cpp:
(keyNameFromJSValue):
LayoutTests:
* platform/efl/Skipped: Unskipped keyboard-related tests.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (118403 => 118404)
--- trunk/LayoutTests/ChangeLog 2012-05-24 19:29:19 UTC (rev 118403)
+++ trunk/LayoutTests/ChangeLog 2012-05-24 19:38:10 UTC (rev 118404)
@@ -1,3 +1,12 @@
+2012-05-24 Mikhail Pozdnyakov <mikhail.pozdnya...@intel.com>
+
+ [EFL] [DRT] keyboard-related tests do not pass
+ https://bugs.webkit.org/show_bug.cgi?id=85369
+
+ Reviewed by Gustavo Noronha Silva.
+
+ * platform/efl/Skipped: Unskipped keyboard-related tests.
+
2012-05-24 Joshua Bell <jsb...@chromium.org>
[Chromium] Widen test suppressions to include linux crash.
Modified: trunk/LayoutTests/platform/efl/Skipped (118403 => 118404)
--- trunk/LayoutTests/platform/efl/Skipped 2012-05-24 19:29:19 UTC (rev 118403)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-05-24 19:38:10 UTC (rev 118404)
@@ -602,11 +602,6 @@
fast/events/drag-in-frames.html
fast/events/drag-parent-node.html
-# BUG: keyboard-related bugs, generally in the EventSender-PlatformKeyboardEventEfl interaction
-fast/events/key-events-in-input-button.html
-fast/events/key-events-in-input-text.html
-fast/events/option-tab.html
-
# BUG: not scrolling correctly
fast/events/mousedown-in-subframe-scrollbar.html
fast/events/scroll-after-click-on-tab-index.html
Modified: trunk/Tools/ChangeLog (118403 => 118404)
--- trunk/Tools/ChangeLog 2012-05-24 19:29:19 UTC (rev 118403)
+++ trunk/Tools/ChangeLog 2012-05-24 19:38:10 UTC (rev 118404)
@@ -1,3 +1,17 @@
+2012-05-24 Mikhail Pozdnyakov <mikhail.pozdnya...@intel.com>
+
+ [EFL] [DRT] keyboard-related tests do not pass
+ https://bugs.webkit.org/show_bug.cgi?id=85369
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Add SHIFT modifier for capital letters as VK_
+ codes do not distinguish between lows and caps and also to be consistent
+ with other ports which send caps as lowercase letters with the shift key down.
+
+ * DumpRenderTree/efl/EventSender.cpp:
+ (keyNameFromJSValue):
+
2012-05-24 Alexey Proskuryakov <a...@apple.com>
[WK2] Let the client give local files universal access on a case by case basis
Modified: trunk/Tools/DumpRenderTree/efl/EventSender.cpp (118403 => 118404)
--- trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2012-05-24 19:29:19 UTC (rev 118403)
+++ trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2012-05-24 19:38:10 UTC (rev 118404)
@@ -487,6 +487,9 @@
if (charCode == '\x1B')
return new KeyEventInfo("Escape", "Escape", modifiers);
+ if ((character->length() == 1) && (charCode >= 'A' && charCode <= 'Z'))
+ modifiers |= EvasKeyModifierShift;
+
return new KeyEventInfo(character->ustring().utf8(), character->ustring().utf8(), modifiers);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
