Title: [124019] trunk/Source/WebCore
Revision
124019
Author
[email protected]
Date
2012-07-30 06:20:59 -0700 (Mon, 30 Jul 2012)

Log Message

Remove an useless member variable, m_shouldPreventDispatch, from EventDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=92625

Reviewed by Hajime Morita.

EventDispatcher::m_shouldPreventDispatch does not have any effects. We can remove that.

No new tests, no behavior change.

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchEvent):
* dom/EventDispatcher.h:
(EventDispatcher):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (124018 => 124019)


--- trunk/Source/WebCore/ChangeLog	2012-07-30 13:17:13 UTC (rev 124018)
+++ trunk/Source/WebCore/ChangeLog	2012-07-30 13:20:59 UTC (rev 124019)
@@ -1,3 +1,20 @@
+2012-07-30  Hayato Ito  <[email protected]>
+
+        Remove an useless member variable, m_shouldPreventDispatch, from EventDispatcher.
+        https://bugs.webkit.org/show_bug.cgi?id=92625
+
+        Reviewed by Hajime Morita.
+
+        EventDispatcher::m_shouldPreventDispatch does not have any effects. We can remove that.
+
+        No new tests, no behavior change.
+
+        * dom/EventDispatcher.cpp:
+        (WebCore::EventDispatcher::EventDispatcher):
+        (WebCore::EventDispatcher::dispatchEvent):
+        * dom/EventDispatcher.h:
+        (EventDispatcher):
+
 2012-07-26  Yury Semikhatsky  <[email protected]>
 
         Web Inspector: make MemoryInstrumentation methods private

Modified: trunk/Source/WebCore/dom/EventDispatcher.cpp (124018 => 124019)


--- trunk/Source/WebCore/dom/EventDispatcher.cpp	2012-07-30 13:17:13 UTC (rev 124018)
+++ trunk/Source/WebCore/dom/EventDispatcher.cpp	2012-07-30 13:20:59 UTC (rev 124019)
@@ -201,7 +201,6 @@
 EventDispatcher::EventDispatcher(Node* node)
     : m_node(node)
     , m_ancestorsInitialized(false)
-    , m_shouldPreventDispatch(false)
 {
     ASSERT(node);
     m_view = node->document()->view();
@@ -254,7 +253,7 @@
 
     // Give the target node a chance to do some work before DOM event handlers get a crack.
     void* data = ""
-    if (m_ancestors.isEmpty() || m_shouldPreventDispatch || event->propagationStopped())
+    if (m_ancestors.isEmpty() || event->propagationStopped())
         goto doneDispatching;
 
     // Trigger capturing event handlers, starting at the top and working our way down.

Modified: trunk/Source/WebCore/dom/EventDispatcher.h (124018 => 124019)


--- trunk/Source/WebCore/dom/EventDispatcher.h	2012-07-30 13:17:13 UTC (rev 124018)
+++ trunk/Source/WebCore/dom/EventDispatcher.h	2012-07-30 13:20:59 UTC (rev 124019)
@@ -84,7 +84,6 @@
     RefPtr<Node> m_node;
     RefPtr<FrameView> m_view;
     bool m_ancestorsInitialized;
-    bool m_shouldPreventDispatch;
 };
 
 inline Node* EventDispatcher::node() const
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to