Title: [124020] trunk/Tools
Revision
124020
Author
[email protected]
Date
2012-07-30 06:21:24 -0700 (Mon, 30 Jul 2012)

Log Message

[Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work
https://bugs.webkit.org/show_bug.cgi?id=92627

Patch by Balazs Kelemen <[email protected]> on 2012-07-30
Reviewed by Noam Rosenthal.

Remove the default behavior I added in r123729 so that we run all tests as pixel
test with -p. It was intentional but it seems like we don't have consensus on
that we want it.

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._supports_switching_pixel_tests_per_test):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (124019 => 124020)


--- trunk/Tools/ChangeLog	2012-07-30 13:20:59 UTC (rev 124019)
+++ trunk/Tools/ChangeLog	2012-07-30 13:21:24 UTC (rev 124020)
@@ -1,3 +1,17 @@
+2012-07-30  Balazs Kelemen  <[email protected]>
+
+        [Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work
+        https://bugs.webkit.org/show_bug.cgi?id=92627
+
+        Reviewed by Noam Rosenthal.
+
+        Remove the default behavior I added in r123729 so that we run all tests as pixel
+        test with -p. It was intentional but it seems like we don't have consensus on
+        that we want it.
+
+        * Scripts/webkitpy/layout_tests/port/qt.py:
+        (QtPort._supports_switching_pixel_tests_per_test):
+
 2012-07-30  Mikhail Pozdnyakov  <[email protected]>
 
         [EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender.

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py (124019 => 124020)


--- trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py	2012-07-30 13:20:59 UTC (rev 124019)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py	2012-07-30 13:21:24 UTC (rev 124020)
@@ -187,10 +187,3 @@
     def _supports_switching_pixel_tests_per_test(self):
         return True
 
-    def _should_run_as_pixel_test(self, test_input):
-        return any(test_input.test_name.startswith(directory)
-                   for directory in QtPort._default_pixel_test_directories())
-
-    @staticmethod
-    def _default_pixel_test_directories():
-        return ['compositing']
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to