Title: [140004] trunk/Tools
- Revision
- 140004
- Author
- commit-qu...@webkit.org
- Date
- 2013-01-17 11:06:16 -0800 (Thu, 17 Jan 2013)
Log Message
[EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
https://bugs.webkit.org/show_bug.cgi?id=107119
Patch by Sudarsana Nagineni <sudarsana.nagin...@intel.com> on 2013-01-17
Reviewed by Laszlo Gombos.
Do not use ASSERT on ecore_evas_init(), since the _expression_ inside
the macro compiles out of release builds.
* TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
* TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (140003 => 140004)
--- trunk/Tools/ChangeLog 2013-01-17 19:04:49 UTC (rev 140003)
+++ trunk/Tools/ChangeLog 2013-01-17 19:06:16 UTC (rev 140004)
@@ -1,3 +1,17 @@
+2013-01-17 Sudarsana Nagineni <sudarsana.nagin...@intel.com>
+
+ [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
+ https://bugs.webkit.org/show_bug.cgi?id=107119
+
+ Reviewed by Laszlo Gombos.
+
+ Do not use ASSERT on ecore_evas_init(), since the _expression_ inside
+ the macro compiles out of release builds.
+
+ * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
+ * TestWebKitAPI/efl/PlatformWebView.cpp:
+ (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
+
2013-01-17 Eugene Klyuchnikov <eus...@chromium.org>
Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
Modified: trunk/Tools/TestWebKitAPI/PlatformEfl.cmake (140003 => 140004)
--- trunk/Tools/TestWebKitAPI/PlatformEfl.cmake 2013-01-17 19:04:49 UTC (rev 140003)
+++ trunk/Tools/TestWebKitAPI/PlatformEfl.cmake 2013-01-17 19:06:16 UTC (rev 140004)
@@ -77,6 +77,7 @@
PreventEmptyUserAgent
PrivateBrowsingPushStateNoHistoryCallback
ShouldGoToBackForwardListItem
+ UserMessage
WKConnection
WKPreferences
WKString
@@ -99,7 +100,3 @@
#
# ResponsivenessTimerDoesntFireEarly
# SpacebarScrolling
-#
-# Flaky test, fails on Release but passes on Debug:
-#
-# UserMessage
Modified: trunk/Tools/TestWebKitAPI/efl/PlatformWebView.cpp (140003 => 140004)
--- trunk/Tools/TestWebKitAPI/efl/PlatformWebView.cpp 2013-01-17 19:04:49 UTC (rev 140003)
+++ trunk/Tools/TestWebKitAPI/efl/PlatformWebView.cpp 2013-01-17 19:06:16 UTC (rev 140004)
@@ -39,7 +39,8 @@
static Ecore_Evas* initEcoreEvas()
{
- ASSERT(ecore_evas_init());
+ if (!ecore_evas_init())
+ return 0;
const char* engine = 0;
#if defined(WTF_USE_ACCELERATED_COMPOSITING) && defined(HAVE_ECORE_X)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
