Title: [140006] trunk
- Revision
- 140006
- Author
- mrobin...@webkit.org
- Date
- 2013-01-17 11:13:12 -0800 (Thu, 17 Jan 2013)
Log Message
REGRESSION (r137487): Crashes in editing/execCommand/indent-paragraphs.html on GTK, EFL
https://bugs.webkit.org/show_bug.cgi?id=105042
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Explicitly handle the situation where the creation of a SoupURI fails. This
can happen if the URI is invalid. In that case the constructor returns null.
No new tests. This patch unskips a failing test.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupRequestAndMessageForHandle): Handle a null Soup URI.
LayoutTests:
Unskip a test which is now passing.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (140005 => 140006)
--- trunk/LayoutTests/ChangeLog 2013-01-17 19:09:16 UTC (rev 140005)
+++ trunk/LayoutTests/ChangeLog 2013-01-17 19:13:12 UTC (rev 140006)
@@ -1,3 +1,14 @@
+2013-01-17 Martin Robinson <mrobin...@igalia.com>
+
+ REGRESSION (r137487): Crashes in editing/execCommand/indent-paragraphs.html on GTK, EFL
+ https://bugs.webkit.org/show_bug.cgi?id=105042
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Unskip a test which is now passing.
+
+ * platform/gtk/TestExpectations:
+
2013-01-17 Nate Chapin <jap...@chromium.org>
Enable reuse of cached main resources
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (140005 => 140006)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2013-01-17 19:09:16 UTC (rev 140005)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-01-17 19:13:12 UTC (rev 140006)
@@ -481,8 +481,6 @@
webkit.org/b/104684 fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html [ Crash Pass ]
-webkit.org/b/105042 editing/execCommand/indent-paragraphs.html [ Crash ]
-
webkit.org/b/105689 [ Debug ] plugins/npruntime/embed-property-iframe-equality.html [ Crash ]
webkit.org/b/106922 accessibility/aria-tables.html [ Crash ]
Modified: trunk/Source/WebCore/ChangeLog (140005 => 140006)
--- trunk/Source/WebCore/ChangeLog 2013-01-17 19:09:16 UTC (rev 140005)
+++ trunk/Source/WebCore/ChangeLog 2013-01-17 19:13:12 UTC (rev 140006)
@@ -1,3 +1,18 @@
+2013-01-17 Martin Robinson <mrobin...@igalia.com>
+
+ REGRESSION (r137487): Crashes in editing/execCommand/indent-paragraphs.html on GTK, EFL
+ https://bugs.webkit.org/show_bug.cgi?id=105042
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Explicitly handle the situation where the creation of a SoupURI fails. This
+ can happen if the URI is invalid. In that case the constructor returns null.
+
+ No new tests. This patch unskips a failing test.
+
+ * platform/network/soup/ResourceHandleSoup.cpp:
+ (WebCore::createSoupRequestAndMessageForHandle): Handle a null Soup URI.
+
2013-01-17 Nate Chapin <jap...@chromium.org>
Enable reuse of cached main resources
Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (140005 => 140006)
--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2013-01-17 19:09:16 UTC (rev 140005)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2013-01-17 19:13:12 UTC (rev 140006)
@@ -985,6 +985,9 @@
GOwnPtr<GError> error;
GOwnPtr<SoupURI> soupURI(request.soupURI());
+ if (!soupURI)
+ return false;
+
d->m_soupRequest = adoptGRef(soup_requester_request_uri(requester, soupURI.get(), &error.outPtr()));
if (error) {
d->m_soupRequest.clear();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
