Title: [171831] trunk/Source/WebCore
- Revision
- 171831
- Author
- [email protected]
- Date
- 2014-07-30 20:15:10 -0700 (Wed, 30 Jul 2014)
Log Message
Clean up YouTubeEmbedShadowElement
https://bugs.webkit.org/show_bug.cgi?id=135437
Patch by Benjamin Poulain <[email protected]> on 2014-07-30
Reviewed by Andreas Kling.
* html/shadow/YouTubeEmbedShadowElement.cpp:
(WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):
(WebCore::YouTubeEmbedShadowElement::pluginElement): Deleted.
This is unused in WebCore.
(WebCore::YouTubeEmbedShadowElement::shadowPseudoId): Deleted.
Use the generic pseudo path instead of a custom shadowPseudoId.
* html/shadow/YouTubeEmbedShadowElement.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (171830 => 171831)
--- trunk/Source/WebCore/ChangeLog 2014-07-31 03:14:11 UTC (rev 171830)
+++ trunk/Source/WebCore/ChangeLog 2014-07-31 03:15:10 UTC (rev 171831)
@@ -1,5 +1,21 @@
2014-07-30 Benjamin Poulain <[email protected]>
+ Clean up YouTubeEmbedShadowElement
+ https://bugs.webkit.org/show_bug.cgi?id=135437
+
+ Reviewed by Andreas Kling.
+
+ * html/shadow/YouTubeEmbedShadowElement.cpp:
+ (WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):
+ (WebCore::YouTubeEmbedShadowElement::pluginElement): Deleted.
+ This is unused in WebCore.
+
+ (WebCore::YouTubeEmbedShadowElement::shadowPseudoId): Deleted.
+ Use the generic pseudo path instead of a custom shadowPseudoId.
+ * html/shadow/YouTubeEmbedShadowElement.h:
+
+2014-07-30 Benjamin Poulain <[email protected]>
+
Remove shadowPseudoId() from InputFieldSpeechButtonElement and SearchFieldCancelButtonElement
https://bugs.webkit.org/show_bug.cgi?id=135438
Modified: trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp (171830 => 171831)
--- trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp 2014-07-31 03:14:11 UTC (rev 171830)
+++ trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp 2014-07-31 03:15:10 UTC (rev 171831)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2012, 2014 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -30,8 +30,6 @@
namespace WebCore {
-using namespace HTMLNames;
-
PassRefPtr<YouTubeEmbedShadowElement> YouTubeEmbedShadowElement::create(Document& doc)
{
return adoptRef(new YouTubeEmbedShadowElement(doc));
@@ -40,7 +38,7 @@
YouTubeEmbedShadowElement::YouTubeEmbedShadowElement(Document& document)
: HTMLDivElement(HTMLNames::divTag, document)
{
- setPseudo(shadowPseudoId());
+ setPseudo(AtomicString("-webkit-plugin-replacement", AtomicString::ConstructFromLiteral));
setInlineStyleProperty(CSSPropertyDisplay, CSSValueInlineBlock);
setInlineStyleProperty(CSSPropertyPosition, CSSValueRelative);
@@ -48,17 +46,4 @@
setInlineStyleProperty(CSSPropertyHeight, CSSValue100);
}
-HTMLPlugInImageElement* YouTubeEmbedShadowElement::pluginElement() const
-{
- Node* node = const_cast<YouTubeEmbedShadowElement*>(this)->deprecatedShadowAncestorNode();
- ASSERT(!node || embedTag == toElement(node)->tagQName() || objectTag == toElement(node)->tagQName());
- return static_cast<HTMLPlugInImageElement*>(node);
}
-
-const AtomicString& YouTubeEmbedShadowElement::shadowPseudoId() const
-{
- DEPRECATED_DEFINE_STATIC_LOCAL(AtomicString, pseudoId, ("-webkit-plugin-replacement"));
- return pseudoId;
-}
-
-}
Modified: trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h (171830 => 171831)
--- trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h 2014-07-31 03:14:11 UTC (rev 171830)
+++ trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h 2014-07-31 03:15:10 UTC (rev 171831)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2012, 2014 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -31,15 +31,10 @@
namespace WebCore {
-class HTMLPlugInImageElement;
-
class YouTubeEmbedShadowElement final : public HTMLDivElement {
public:
static PassRefPtr<YouTubeEmbedShadowElement> create(Document&);
- virtual const AtomicString& shadowPseudoId() const override;
- HTMLPlugInImageElement* pluginElement() const;
-
private:
YouTubeEmbedShadowElement(Document&);
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
