Title: [171832] trunk/Source/WebCore
- Revision
- 171832
- Author
- [email protected]
- Date
- 2014-07-30 20:16:05 -0700 (Wed, 30 Jul 2014)
Log Message
Remove SpinButtonElement::shadowPseudoId
https://bugs.webkit.org/show_bug.cgi?id=135436
Patch by Benjamin Poulain <[email protected]> on 2014-07-30
Reviewed by Andreas Kling.
Use the generic pseudo.
* html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::shadowPseudoId): Deleted.
* html/shadow/SpinButtonElement.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (171831 => 171832)
--- trunk/Source/WebCore/ChangeLog 2014-07-31 03:15:10 UTC (rev 171831)
+++ trunk/Source/WebCore/ChangeLog 2014-07-31 03:16:05 UTC (rev 171832)
@@ -1,5 +1,19 @@
2014-07-30 Benjamin Poulain <[email protected]>
+ Remove SpinButtonElement::shadowPseudoId
+ https://bugs.webkit.org/show_bug.cgi?id=135436
+
+ Reviewed by Andreas Kling.
+
+ Use the generic pseudo.
+
+ * html/shadow/SpinButtonElement.cpp:
+ (WebCore::SpinButtonElement::SpinButtonElement):
+ (WebCore::SpinButtonElement::shadowPseudoId): Deleted.
+ * html/shadow/SpinButtonElement.h:
+
+2014-07-30 Benjamin Poulain <[email protected]>
+
Clean up YouTubeEmbedShadowElement
https://bugs.webkit.org/show_bug.cgi?id=135437
Modified: trunk/Source/WebCore/html/shadow/SpinButtonElement.cpp (171831 => 171832)
--- trunk/Source/WebCore/html/shadow/SpinButtonElement.cpp 2014-07-31 03:15:10 UTC (rev 171831)
+++ trunk/Source/WebCore/html/shadow/SpinButtonElement.cpp 2014-07-31 03:16:05 UTC (rev 171832)
@@ -52,6 +52,7 @@
, m_repeatingTimer(this, &SpinButtonElement::repeatingTimerFired)
{
setHasCustomStyleResolveCallbacks();
+ setPseudo(AtomicString("-webkit-inner-spin-button", AtomicString::ConstructFromLiteral));
}
PassRefPtr<SpinButtonElement> SpinButtonElement::create(Document& document, SpinButtonOwner& spinButtonOwner)
@@ -59,12 +60,6 @@
return adoptRef(new SpinButtonElement(document, spinButtonOwner));
}
-const AtomicString& SpinButtonElement::shadowPseudoId() const
-{
- DEPRECATED_DEFINE_STATIC_LOCAL(AtomicString, innerPseudoId, ("-webkit-inner-spin-button", AtomicString::ConstructFromLiteral));
- return innerPseudoId;
-}
-
void SpinButtonElement::willDetachRenderers()
{
releaseCapture();
Modified: trunk/Source/WebCore/html/shadow/SpinButtonElement.h (171831 => 171832)
--- trunk/Source/WebCore/html/shadow/SpinButtonElement.h 2014-07-31 03:15:10 UTC (rev 171831)
+++ trunk/Source/WebCore/html/shadow/SpinButtonElement.h 2014-07-31 03:16:05 UTC (rev 171832)
@@ -69,7 +69,6 @@
private:
SpinButtonElement(Document&, SpinButtonOwner&);
- virtual const AtomicString& shadowPseudoId() const override;
virtual void willDetachRenderers() override;
virtual bool isSpinButtonElement() const override { return true; }
virtual bool isDisabledFormControl() const override { return shadowHost() && shadowHost()->isDisabledFormControl(); }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes