Title: [182220] trunk/Source/WebInspectorUI
- Revision
- 182220
- Author
- jonowe...@apple.com
- Date
- 2015-03-31 22:00:02 -0700 (Tue, 31 Mar 2015)
Log Message
Web Inspector: REGRESSION: Filtering no longer works
https://bugs.webkit.org/show_bug.cgi?id=143099
Reviewed by Brian Burg.
Add a check for an empty array of filter functions and return true in this case to ensure text
and timeline filters work correctly.
* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.matchTreeElementAgainstFilterFunctions):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (182219 => 182220)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-04-01 04:06:07 UTC (rev 182219)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-01 05:00:02 UTC (rev 182220)
@@ -1,3 +1,16 @@
+2015-03-31 Jono Wells <jonowe...@apple.com>
+
+ Web Inspector: REGRESSION: Filtering no longer works
+ https://bugs.webkit.org/show_bug.cgi?id=143099
+
+ Reviewed by Brian Burg.
+
+ Add a check for an empty array of filter functions and return true in this case to ensure text
+ and timeline filters work correctly.
+
+ * UserInterface/Views/NavigationSidebarPanel.js:
+ (WebInspector.NavigationSidebarPanel.prototype.matchTreeElementAgainstFilterFunctions):
+
2015-03-31 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r182186.
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (182219 => 182220)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2015-04-01 04:06:07 UTC (rev 182219)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2015-04-01 05:00:02 UTC (rev 182220)
@@ -303,6 +303,9 @@
matchTreeElementAgainstFilterFunctions(treeElement)
{
+ if (!this._filterFunctions.length)
+ return true;
+
for (var filterFunction of this._filterFunctions) {
if (filterFunction(treeElement))
return true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
