Title: [182221] trunk/Source/WebInspectorUI
- Revision
- 182221
- Author
- nvasil...@apple.com
- Date
- 2015-03-31 23:16:48 -0700 (Tue, 31 Mar 2015)
Log Message
Web Inspector: console.error(object) has double disclosure triangles
https://bugs.webkit.org/show_bug.cgi?id=142069
Use inline-block instead of "float: left" or "position: absolute" to
make layout more predictable and easier to understand.
Reviewed by Timothy Hatcher.
* UserInterface/Views/LogContentView.css:
(.outline-disclosure, .outline-disclosure ol):
(.outline-disclosure > li.parent):
(.outline-disclosure > li.parent::before):
(.outline-disclosure li.parent): Deleted.
(.outline-disclosure li.parent::before): Deleted.
* UserInterface/Views/ObjectTreePropertyTreeElement.css:
(.object-tree-property > .titles):
(.object-tree-property > .disclosure-button):
(.object-tree-property > .icon):
* UserInterface/Views/ObjectTreeView.css:
(.object-tree > :matches(.title, .object-preview)::before):
(.object-tree:not(.lossless-preview) > :matches(.title, .object-preview)):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (182220 => 182221)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-04-01 05:00:02 UTC (rev 182220)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-01 06:16:48 UTC (rev 182221)
@@ -1,3 +1,27 @@
+2015-03-31 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: console.error(object) has double disclosure triangles
+ https://bugs.webkit.org/show_bug.cgi?id=142069
+
+ Use inline-block instead of "float: left" or "position: absolute" to
+ make layout more predictable and easier to understand.
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/LogContentView.css:
+ (.outline-disclosure, .outline-disclosure ol):
+ (.outline-disclosure > li.parent):
+ (.outline-disclosure > li.parent::before):
+ (.outline-disclosure li.parent): Deleted.
+ (.outline-disclosure li.parent::before): Deleted.
+ * UserInterface/Views/ObjectTreePropertyTreeElement.css:
+ (.object-tree-property > .titles):
+ (.object-tree-property > .disclosure-button):
+ (.object-tree-property > .icon):
+ * UserInterface/Views/ObjectTreeView.css:
+ (.object-tree > :matches(.title, .object-preview)::before):
+ (.object-tree:not(.lossless-preview) > :matches(.title, .object-preview)):
+
2015-03-31 Jono Wells <jonowe...@apple.com>
Web Inspector: REGRESSION: Filtering no longer works
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (182220 => 182221)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2015-04-01 05:00:02 UTC (rev 182220)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2015-04-01 06:16:48 UTC (rev 182221)
@@ -377,7 +377,7 @@
.outline-disclosure, .outline-disclosure ol {
list-style-type: none;
- -webkit-padding-start: 12px;
+ -webkit-padding-start: 0;
margin: 0;
}
@@ -393,7 +393,7 @@
margin-bottom: 2px;
}
-.outline-disclosure li.parent {
+.outline-disclosure > li.parent {
margin-left: -12px
}
@@ -401,7 +401,7 @@
margin-left: -12px;
}
-.outline-disclosure li.parent::before {
+.outline-disclosure > li.parent::before {
float: left;
content: "";
@@ -413,7 +413,7 @@
width: 8px;
height: 8px;
- margin-top: 4px;
+ margin-top: 3px;
padding-right: 2px;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css (182220 => 182221)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css 2015-04-01 05:00:02 UTC (rev 182220)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.css 2015-04-01 06:16:48 UTC (rev 182221)
@@ -35,10 +35,13 @@
text-overflow: ellipsis;
overflow: hidden;
white-space: nowrap;
+ display: inline-block;
+ vertical-align: top;
}
.object-tree-property > .disclosure-button {
- float: left;
+ display: inline-block;
+ vertical-align: top;
width: 16px;
height: 16px;
@@ -61,7 +64,8 @@
}
.object-tree-property > .icon {
- float: left;
+ display: inline-block;
+ vertical-align: top;
position: relative;
width: 16px;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css (182220 => 182221)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css 2015-04-01 05:00:02 UTC (rev 182220)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css 2015-04-01 06:16:48 UTC (rev 182221)
@@ -32,10 +32,11 @@
}
.object-tree > :matches(.title, .object-preview)::before {
- position: absolute;
+ display: inline-block;
- top: 0;
- left: -2px;
+ vertical-align: baseline;
+ margin-bottom: -2px;
+ margin-right: 2px;
width: 13px;
height: 13px;
@@ -49,7 +50,7 @@
}
.object-tree:not(.lossless-preview) > :matches(.title, .object-preview) {
- margin-left: 13px;
+ margin-left: 1px;
}
.object-tree.expanded > :matches(.title, .object-preview)::before {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
