On Nov 5, 2008, at 10:22 AM, Darin Fisher wrote:
On Wed, Nov 5, 2008 at 7:04 AM, Maciej Stachowiak <[EMAIL PROTECTED]>
wrote:
On Oct 30, 2008, at 9:47 AM, Darin Fisher wrote:
We have code to support this feature in the Chromium code base.
You can find it here:
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/dom_serializer.h?view=markup
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/dom_serializer.cc?view=markup
It is something we would love to one day see as part of WebKit.
WebKit already includes code to serialize the DOM, in WebCore/
editing/markup.cpp. This is used by innerHTML, XMLSerializer, the
clipboard code, Web archives, and other things. I think a better
approach to a "save as Web page, complete" style feature would be to
use the existing DOM serialization code (fixing bugs, if necessary),
instead of adding completely separate DOM serialization code. The
only tricky part is fixing up URL references in the markup to point
to the right place for saved subresources.
Regards,
Maciej
I agree. I would rather see that happen too. Our code was created
because we didn't want to fork WebCore, but we are happy to see it
die in favor of enchancements to markup.cpp. There is more than
just fixing up URLs. We also need to deal with charset encoding
issues, base tags, and motw (for windows). There may be a few other
subtle details to get right.
Your code also has some obvious bugs that are not in the WebCore code.
For instance it serializes the following incorrectly:
<p style="color: red"></p>
<b>bold line</b>
Regards,
Maciej
_______________________________________________
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
