On Wed, Jul 22, 2009 at 5:35 PM, Eric Seidel <[email protected]> wrote:
> Now from the right email address. > > On Wed, Jul 22, 2009 at 5:34 PM, Eric Seidel<[email protected]> wrote: > > http://trac.webkit.org/changeset/45938 added DOMConstructorObject, but > > did not change most constructors (the autogen'd ones). > > > > > > I'm now removing the autogen'd createStructure and making all > > constructors inherit from DOMConstructorObject. > > > > The autogen'd version: > > > > static PassRefPtr<Structure> createStructure(JSValue proto) > > { > > return Structure::create(proto, TypeInfo(ObjectType, > > ImplementsHasInstance)); > > } > > > > DOMConstructorObject's: > > > > static PassRefPtr<JSC::Structure> createStructure(JSC::JSValue prototype) > > { > > return JSC::Structure::create(prototype, > > JSC::TypeInfo(JSC::ObjectType, JSC::HasStandardGetOwnPropertySlot | > > JSC::ImplementsHasInstance)); > > } > > > > What is HasStandardGetOwnPropertySlot adding? Is it testable? >From ChangeLog descriptions (https://trac.webkit.org/changeset/37799 by Darin Adler), it sounds like it means "this class doesn't override getPropertySlot." I would suspect that you'd get a build error if it was set incorrectly. > > > > > -eric > > > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
