Never mind. I've looked at the source, and understand enough to see that that looks like a bad idea. Autogen'd constructors seem to always assume that the ConstructorTable will be non-empty, and thus they need to have a custom getOwnPropertySlot. So I'll leave the autogen'd code for now. It doesn't hurt that a superclass also overrides createStructure().
Almost seems like these flags should be in a separate function, and that there should be one shared createStructure(). On Wed, Jul 22, 2009 at 5:35 PM, Eric Seidel<[email protected]> wrote: > Now from the right email address. > > On Wed, Jul 22, 2009 at 5:34 PM, Eric Seidel<[email protected]> wrote: >> http://trac.webkit.org/changeset/45938 added DOMConstructorObject, but >> did not change most constructors (the autogen'd ones). >> >> >> I'm now removing the autogen'd createStructure and making all >> constructors inherit from DOMConstructorObject. >> >> The autogen'd version: >> >> static PassRefPtr<Structure> createStructure(JSValue proto) >> { >> return Structure::create(proto, TypeInfo(ObjectType, >> ImplementsHasInstance)); >> } >> >> DOMConstructorObject's: >> >> static PassRefPtr<JSC::Structure> createStructure(JSC::JSValue prototype) >> { >> return JSC::Structure::create(prototype, >> JSC::TypeInfo(JSC::ObjectType, JSC::HasStandardGetOwnPropertySlot | >> JSC::ImplementsHasInstance)); >> } >> >> What is HasStandardGetOwnPropertySlot adding? Is it testable? >> >> -eric >> > _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
