On Thu, Nov 17, 2011 at 4:53 PM, Tony Chang <t...@chromium.org> wrote: > new-run-webkit-httpd imports common/host.py which imports lots of stuff > including common/net/buildbot.py, which will fail to import the json module. > I would land smaller pieces so the rollback isn't as painful. :)
Adam appears to have listed the files: http://codesearch.google.com/#search/&exact_package=chromium&q=new-run-webkit&type=cs Can someone with chromium commit-bit, please move those 3 files to call python 2.7 in whatever the proper way is, so we can move forward here? -eric > On Thu, Nov 17, 2011 at 4:42 PM, Adam Barth <aba...@webkit.org> wrote: >> >> The remaining things seem related to websocket-server and >> new-run-webkit-httpd, which I don't think will be effected by your >> change. >> >> Adam >> >> >> On Thu, Nov 17, 2011 at 4:40 PM, Eric Seidel <e...@webkit.org> wrote: >> > Other bot steps in Chromium depend on webkitpy? >> > >> > I'm tempted to just make the change and see what breaks. We can >> > always roll it out if things are really bad. >> > >> > I'll prepare an updated patch. >> > >> > -eric >> > >> > On Thu, Nov 17, 2011 at 4:37 PM, Tony Chang <t...@chromium.org> wrote: >> >> Only new-run-webkit-tests uses python 2.7 on the leopard bots. There >> >> are >> >> other bot steps in chromium that would break. I mention a couple cases >> >> here: >> >> http://code.google.com/p/chromium/issues/detail?id=103266#c6 >> >> Alternately, we could try to fully switch the leopard bots to 2.7 >> >> (http://crbug.com/103828), but that's a larger task. >> >> >> >> On Thu, Nov 17, 2011 at 3:19 PM, Dirk Pranke <dpra...@chromium.org> >> >> wrote: >> >>> >> >>> On Thu, Nov 17, 2011 at 2:45 PM, Adam Barth <aba...@webkit.org> wrote: >> >>> > On Thu, Nov 17, 2011 at 2:42 PM, Dirk Pranke <dpra...@chromium.org> >> >>> > wrote: >> >>> >> The Chromium Leopard bots are still using 2.5 as far as I know. >> >>> >> Unless >> >>> >> "move forward" includes you upgrading those bots, you shouldn't >> >>> >> remove >> >>> >> the 2.5 compat code until they have been upgraded. (If you are >> >>> >> signing >> >>> >> up to upgrade them, then great!). >> >>> > >> >>> > Tony already upgraded the bots. >> >>> > >> >>> > Adam >> >>> > >> >>> >> >>> I have been corrected. You have my blessings :). >> >>> _______________________________________________ >> >>> webkit-dev mailing list >> >>> webkit-dev@lists.webkit.org >> >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> >> >> >> >> _______________________________________________ >> >> webkit-dev mailing list >> >> webkit-dev@lists.webkit.org >> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> >> >> >> > _______________________________________________ >> > webkit-dev mailing list >> > webkit-dev@lists.webkit.org >> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > > > _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
