(Sorry if we're spamming webkit-dev with this thread. We can move it to a Chromium infrastructure mailing list if we're bugging anyone.)
On Thu, Nov 17, 2011 at 5:17 PM, Dirk Pranke <[email protected]> wrote: > On Thu, Nov 17, 2011 at 5:06 PM, Eric Seidel <[email protected]> wrote: >> On Thu, Nov 17, 2011 at 4:53 PM, Tony Chang <[email protected]> wrote: >>> new-run-webkit-httpd imports common/host.py which imports lots of stuff >>> including common/net/buildbot.py, which will fail to import the json module. >>> I would land smaller pieces so the rollback isn't as painful. :) >> >> Adam appears to have listed the files: >> http://codesearch.google.com/#search/&exact_package=chromium&q=new-run-webkit&type=cs >> >> Can someone with chromium commit-bit, please move those 3 files to >> call python 2.7 in whatever the proper way is, so we can move forward >> here? > > 2.7? Aren't we just requiring 2.6? I don't think any of the Chromium > bots can assume 2.7 (except for the ones Tony has upgraded), and none > of my machines (except for maybe my Lion machine at home) even have > 2.7 installed. The pattern Tony used for new-run-webkit-tests was to detect whether Python 2.7 was installed at a certain path before trying to use it. That pattern seems like it would work in these cases too. The one tricky one is ui_test because the launcher is in C++. Perhaps it should call a wrapper script instead? Adam _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
