On Tue, May 29, 2012 at 7:23 PM, Konrad Piascik <kpias...@rim.com> wrote: > How will these changes affect window.devicePixelRatio and the associated > media queries? Will they still key off of Page::deviceScaleFactor?
There's been a bunch of discussion about that topic in <https://bugs.webkit.org/show_bug.cgi?id=87407>. The short answer is that they will be keyed off of Page::deviceScaleFactor, which means they won't be affected by changes to the target-densitydpi. Adam > ----- Original Message ----- > From: Adam Barth [mailto:aba...@webkit.org] > Sent: Tuesday, May 29, 2012 10:10 PM > To: Fady Samuel <fsam...@chromium.org> > Cc: kenn...@webkit.org <kenn...@webkit.org>; webkit-dev@lists.webkit.org > <webkit-dev@lists.webkit.org> > Subject: Re: [webkit-dev] Device and page scaling > > On Tue, May 29, 2012 at 7:03 PM, Fady Samuel <fsam...@chromium.org> wrote: >> This sounds good to me, but is there any reason why we can't support >> physical device changes (switching monitors) and support target-densitydpi? >> This would be highly desirable for us. > > We can support that. We just need to decide how to change the > effective device scale factor when the actual device scale factor > changes. > > Adam > > >>> == Page::effectiveDeviceScaleFactor == >>> >>> Page::effectiveDeviceScaleFactor starts off as matching >>> Page::deviceScaleFactor but changes to reflect any target-densitydpi >>> directives. It's unclear to me how Page::effectiveDeviceScaleFactor >>> should react when the underlying physical device changes its scaling >>> factor. Currently, that shouldn't occur, so I'm inclined to add an >>> ASSERT and worry about it later. >>> >>> == Settings::defaultDeviceScaleFactor == >>> >>> This variable will be deleted. >>> >>> Thoughts? >>> Adam >> >> > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > --------------------------------------------------------------------- > This transmission (including any attachments) may contain confidential > information, privileged material (including material protected by the > solicitor-client or other applicable privileges), or constitute non-public > information. Any use of this information by anyone other than the intended > recipient is prohibited. If you have received this transmission in error, > please immediately reply to the sender and delete this information from your > system. Use, dissemination, distribution, or reproduction of this > transmission by unintended recipients is not authorized and may be unlawful. _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
