Can you explain why the target-densitydpi feature even exists? It seems ill-conceived to me, and the most straightforward fix would be to remove it. I have not heard anyone explain the use case for it. (I'm also not clear on the details of what it actually does, and neither the name nor the docs are enlightening.)
Regards, Maciej On May 29, 2012, at 7:03 PM, Fady Samuel <fsam...@chromium.org> wrote: > This sounds good to me, but is there any reason why we can't support physical > device changes (switching monitors) and support target-densitydpi? This would > be highly desirable for us. > > Fady > > == Page::effectiveDeviceScaleFactor == > > Page::effectiveDeviceScaleFactor starts off as matching > Page::deviceScaleFactor but changes to reflect any target-densitydpi > directives. It's unclear to me how Page::effectiveDeviceScaleFactor > should react when the underlying physical device changes its scaling > factor. Currently, that shouldn't occur, so I'm inclined to add an > ASSERT and worry about it later. > > == Settings::defaultDeviceScaleFactor == > > This variable will be deleted. > > Thoughts? > Adam > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
