How about ASSERT_USING and ASSERT_WITH_MESSAGE_USING? If we use a variable in an assert it's no longer unused…
e.g. ASSERT_USING(timer, timer == &m_resumeTimer); On Oct 1, 2012, at 6:17 PM, ext Mike Lawther <[email protected]<mailto:[email protected]>> wrote: ASSERT_WITH_OTHERWISE_UNUSED. On 2 October 2012 10:51, Ryosuke Niwa <[email protected]<mailto:[email protected]>> wrote: How about ASSERT_OR_UNUSED or ASSERT_USING_UNUSED? On Mon, Oct 1, 2012 at 5:23 PM, Darin Adler <[email protected]<mailto:[email protected]>> wrote: On Oct 1, 2012, at 5:21 PM, Mike Lawther <[email protected]<mailto:[email protected]>> wrote: > my first reading of that name had me thinking it meant 'ASSERT that this > variable is unused' in the vein of macros I've seen in other places like > ASSERT_TRUE, ASSERT_NOT_NULL etc. Yes, even though I named the macro I have had the same thought often. I love the macro, but a better name, even if a bit longer, would be welcome. If we can think of one we can fix this with a quick global replace. -- Darin _______________________________________________ webkit-dev mailing list [email protected]<mailto:[email protected]> http://lists.webkit.org/mailman/listinfo/webkit-dev _______________________________________________ webkit-dev mailing list [email protected]<mailto:[email protected]> http://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo/webkit-dev
