If a rewrite does happen, it would be nice to have some generic functionality abstracted away from the specific language generators. For example, the function to add an #include statement to the generated implementation file is currently replicated for every language. JS and V8 have "AddToImplIncludes", while CPP and ObjC have "AddIncludesForType". I personally copy+pasted a lot of code from CPP and JS for the Ruby code generator, and it would be nice if some of that was more generic.
-Tim On Apr 10, 2013, at 6:03 PM, Timothy Hatcher <timo...@apple.com> wrote: > > On Apr 10, 2013, at 8:17 PM, Kentaro Hara <hara...@chromium.org> wrote: > >> Now that JSC is the only engine in WebKit and V8 is the only engine in V8, >> we both can remove a bunch of unnecessary abstractions and IDL attributes >> that had existed to share code between JSC and V8. In short-term, this kind >> of clean-up will improve our situation a lot. (I'm doing the work with the >> highest priority in the V8 side.) > > As I said in a previous email, JSC isn't the only binding we generate with > these scripts. We also generate ObjC and internal Safari bindings. So those > needs need to be considered for anyone rewriting these scripts. > > — Timothy Hatcher > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
