On Fri, Apr 12, 2013 at 11:59 AM, Sergio Villar Senin <svil...@igalia.com>wrote:
> En 12/04/13 19:00, Ryosuke Niwa escribiu: > > On Fri, Apr 12, 2013 at 9:50 AM, Sergio Villar Senin <svil...@igalia.com > > Well, I have a pretty compact patch more or less ready to be > uploaded to > > bz that in the case of the caret being placed at (3) just draws the > > classical 1px width bar (it also draws the thin bar in the case of > being > > after the last character), so although the replaced character is in > any > > case the 1, the insanity you mention is somehow minimized. > > > > > > That doesn't sound right either. It's much more confusing than not > > setting any width at all because the overtype mode is still on. > > > > What we need to do is here to use selection. We need to have > > 1-character long text selection at all time except at the end of each > > line when overtype is on since selection code already deals with the > > said bidi craziness. Anything short of that isn't landable quality. > > Ok, sounds like a very different approach. Just to clarify, do you mean > to skip the caret painting in overtype mode and just use the 1-character > selection as if it were the caret? > Right. In practice, we might be able to do the opposite in the rendering side. Treat overtype caret as if it's 1-character selection when we update the RenderView. - R. Niwa
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
