> On Sep 8, 2022, at 5:41 AM, Adrian Perez de Castro via webkit-dev > <webkit-dev@lists.webkit.org> wrote: > On Thu, 08 Sep 2022 02:27:53 +0000 Alexey Proskuryakov via webkit-dev > <webkit-dev@lists.webkit.org> wrote: >> Without non-unified EWS, or anyone fixing non-unified build manually: >> - a smaller number of patches gets rejected for breaking existing EWS >> builders; >> - it's sometimes harder to fix, because the errors could be in unfamiliar >> code (although how hard can it be to add an include, on average). > > Not fixing the build ever would not work. If we don't land patches which are > technically correct there will be always situations in which the build will > randomly break. > > Example: Buildbot (both EWS and post-commit) build with DEVELOPER_MODE=ON and > ENABLE_EXPERIMENTAL_FEATURES=ON, while end user builds disable those. The > changed options can result in shifted sources in the unified build compilation > units. What passes as "yeah, it builds" in the bots could still fail later > when producing releases. This applies to *all* ports.
This is not true. Build flags are if-def’s inside each file, not a condition on whether a given file is unified or not. Enabling or disabling any feature should not affect which set of cpp files are unified together. - R. Niwa _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
