Hi Ossy, I second that. First release of QtWebKit 2.2 (2.2.0) should be baselined on top of Qt 4.7 and QtWebKit 2.2.1 should come with results for Qt 4.8 (and try not to regress between QtWebKit releases).
Regards, Laszlo From: [email protected] [mailto:[email protected]] On Behalf Of ext Andy Kling Sent: Wednesday, September 07, 2011 10:30 AM To: Osztrogonac Csaba Cc: [email protected] Subject: Re: [webkit-qt] Maintaining Qt 4.7 and 4.8 expected results in parallel Hi Ossy, I agree, we should wait until Qt 4.8 is released, then land this patch + rebaseline LayoutTests/platform/qt. Requiring that people manage results from both 4.7 and 4.8 is asking too much IMO. On a related note, qt-wk2 should already be using qt-4.8 as its fallback, but if it's indeed nontrivial, it's not a big deal. Cheers, Kling 2011/9/7 Osztrogonac Csaba <[email protected]<mailto:[email protected]>> Hi QtWebKit developers, I ran into a serious problem what we should solve without any pain. Here is a bug report with an r+ -ed patch: https://bugs.webkit.org/show_bug.cgi?id=55036 [Qt] FontCache::createFontPlatformData() is broken, a default font is returned even if the family does not match After this patch ~5000 layout test result will differ between Qt 4.7 and 4.8, which is absolutly unmaintainable. Additionally WebKit2 builds with Qt 5, but qt-wk2 platform falls back to qt platform and not qt-4.8/qt platforms. I don't know how important is this patch (AFAIK it doesn't block QtWebKit2.2 release), but I think the best solution is if we wait until Qt 4.8 relase and then we drop LayoutTests/platform/qt-4.8 platform and declare that now LayoutTests/platform/qt means Qt 4.8 results and Qt 4.7 layout test results aren't supported anymore. If we want to land this patch now, we have to - fix run-webkit-tests to be able handle qt-wk2/qt-4.8/qt fallback order (It isn't trivial fix.) - add +5000 Qt 4.8 specific layout test result into LayoutTests/platform/qt-4.8 - maintain LayoutTests/platform/qt and LayoutTests/platform/qt-4.8 in parallel ( It is shocking big task !!! ) What do you think about it? What should we do now? br, Csaba Osztrogonác (Ossy) University of Szeged _______________________________________________ webkit-qt mailing list [email protected]<mailto:[email protected]> http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt
_______________________________________________ webkit-qt mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt
