Hi All,
After Qt 4.8.0-rc1 is released, all QtWebKit buildbots were migrated to Qt
4.8.0-rc1.
And then we landed the patch from https://bugs.webkit.org/show_bug.cgi?id=55036.
After this patch ~6000 test results are different with Qt 4.8.0-rc1 and Qt
4.7.4,
so we won't support layout testing with Qt 4.7.4 anymore.
LayoutTests/platform/qt-4.8
was moved to LayoutTests/platform/qt directory and now Qt 4.8 results are the
default.
PS. After final releases of Qt 4.8.0 I will update QBAT Virtual Machine too:
http://webkit.sed.hu/blog/20101028/qtwebkit-builder-and-tester-virtual-machine
br,
Ossy
Andy Kling írta:
Hi Ossy,
I agree, we should wait until Qt 4.8 is released, then land this patch +
rebaseline LayoutTests/platform/qt.
Requiring that people manage results from both 4.7 and 4.8 is asking too
much IMO.
On a related note, qt-wk2 should already be using qt-4.8 as its
fallback, but if it's indeed nontrivial, it's not a big deal.
Cheers,
Kling
2011/9/7 Osztrogonac Csaba <[email protected]
<mailto:[email protected]>>
Hi QtWebKit developers,
I ran into a serious problem what we should solve without any pain.
Here is a bug report with an r+ -ed patch:
https://bugs.webkit.org/show___bug.cgi?id=55036
<https://bugs.webkit.org/show_bug.cgi?id=55036>
[Qt] FontCache::__createFontPlatformData() is broken, a default font
is returned even if the family does not match
After this patch ~5000 layout test result will differ between Qt 4.7
and 4.8,
which is absolutly unmaintainable. Additionally WebKit2 builds with
Qt 5, but
qt-wk2 platform falls back to qt platform and not qt-4.8/qt platforms.
I don't know how important is this patch (AFAIK it doesn't block
QtWebKit2.2 release),
but I think the best solution is if we wait until Qt 4.8 relase and
then we drop
LayoutTests/platform/qt-4.8 platform and declare that now
LayoutTests/platform/qt
means Qt 4.8 results and Qt 4.7 layout test results aren't supported
anymore.
If we want to land this patch now, we have to
- fix run-webkit-tests to be able handle qt-wk2/qt-4.8/qt fallback
order (It isn't trivial fix.)
- add +5000 Qt 4.8 specific layout test result into
LayoutTests/platform/qt-4.8
- maintain LayoutTests/platform/qt and LayoutTests/platform/qt-4.8
in parallel ( It is shocking big task !!! )
What do you think about it? What should we do now?
br,
Csaba Osztrogonác (Ossy)
University of Szeged
_________________________________________________
webkit-qt mailing list
[email protected] <mailto:[email protected]>
http://lists.webkit.org/__mailman/listinfo.cgi/webkit-qt
<http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt>
_______________________________________________
webkit-qt mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt
