Hi All,
Luciano's idea about using rebaseline server for this huge rebasing game
is very good. I did what you suggested, I generated new results on r121970
with old testfonts and then run tests on r122100 (top of trunk this time).
I propose the following method for rebasing:
- Let's concentrate for Qt 5 WebKit1 first (Qt 4.8 and Qt 5.0 WebKit2 results
are very similar,
there are only ~500 different test results on them.) After we finished Qt 5.
- download http://build.webkit.sed.hu/x/layout-test-results.tar.gz , untar it
where you want: my-favourite-path
(download can be slow a little bit, because it is a 330 Mb sized file.)
- Tools/Scripts/webkit-patch rebaseline-server my-favourite-path
- wait, wait and wait :) (starting server took 5-6 minutes for me because of
this huge number of tests)
- Pick a directory for rebasing
- Add a comment to https://bugs.webkit.org/show_bug.cgi?id=85203, for example: "I
started rebasing css2.1 tests."
(To avoid paralel working on same directory.)
- Select baseline target qt (not qt-5.0, qt-5.0-wk1, ...) at the bottom of the
page.
- You can use the following hotkeys for rebasing:
- q - add the actual test for rebasing queue (mark the result good)
- x - remove the actual test for rebasing queue (if you marked it
accidentally)
- left and right arrow - jump to the previous/next test
- r - rebase queued tests - if you finished a bunch of tests
- After rebase, check if there is old expected files in qt-5.0, qt-5.0-wk1,
qt-5.0-wk2, and remove them
- Unskip rebased tests for qt-5.0 and qt-5.0/Skipped lists -
https://bugs.webkit.org/show_bug.cgi?id=85203 block
- Upload the patch to bugzilla, review, land, ...
After we finished rebasing tests for Qt 5.0 WK1, we can check 4.8 and 5.0 WK2
results too. Most of them (~90%)
will pass and we only need to unskip them. We have to check only ~500-500 tests
and commit qt-4.8 and qt-5.0-wk2
specific expected results because of minor pixel differences.
Any opinion? objections?
br,
Ossy
Luciano Wolf írta:
Hi Ossy,
Good job! As this is a small batch of tests compared with the entire
skip list we can deal with it comparing one by one.
I think we can use rebaseline-server to ease our lives. The matter is
that it would be even easier if you provide us your
"WebKitBuild/Release/layout-test-results" directory. Basically you
would need to copy the new expected results into
"webkit/LayoutTests/platform/qt*" (without the patch that skips tests
and change fonts) and run the tests with
"--results-directory=YOUR_DIRECTORY_OF_CHOICE". After that, compress
this resulting directory and we can use "Tools/Scripts/webkit-patch
rebaseline-server OSSY'S_DIRECTORY" to do the rebaseline.
Cheers,
Luciano
On Fri, Jul 6, 2012 at 1:45 PM, Osztrogonac Csaba <[email protected]> wrote:
Hi,
I generated png and txt results on my Ubuntu 11.10 with latest Qt5 and WK1
for all tests skipped by https://trac.webkit.org/changeset/121971 .
You can download them from here:
- http://build.webkit.sed.hu/x/r121970-with-old-testfonts.tar.gz
- http://build.webkit.sed.hu/x/r121972-with-new-testfonts.tar.gz
We only need a good tool to help our manual work. :) For example
a simple script generates a html file contains old and new pngs
and a simple js to be able to go to the next/previous test, etc.
Let's continue with manual checking and unskipping next week. ;-)
I think we can start checking these results one by one and unskip correct
tests and check-in their png and txt result to platform/qt directory. And
then we should add qt-4.8, qt-5.0-wk2 specific results if it is needed.
br,
Ossy
_______________________________________________
webkit-qt mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-qt
