On Feb 6, 10:21 am, "Leslie P. Polzer" <[email protected]> wrote: > > > We could find the parent and use replaceChild() on the target element. > > > I've submitted a pull request with my changes. > > Does it break any tests?
Yeah, ok. So nevermind the pull request until the failing tests are corrected (there are 3). 'detect-dirty-circularity' fails as you might expect, since I'm now replacing the entire widget, not just its children, but what's the best way to fix it? I'm trying to understand what's really meant by 'circular' in this context, but I don't quite follow this snippet: (setf (slot-value a 'other) b) (setf d (list a b)) (weblocks::render-dirty-widgets) (ensure-null d) I see that setting a slot on one widget will cause it to be marked dirty, but two questions: 1) why is 'd' supposed to be null 2) shouldn't only widget 'a' be dirty? --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "weblocks" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/weblocks?hl=en -~----------~----~----~----~------~----~------~--~---
