On Feb 6, 3:26 pm, "Leslie P. Polzer" <[email protected]> wrote: > It looks like you're mixing up two different issues here: > > 1) Number of assertions per test > > 2) Test dependencies > > The lack of dependencies in the current suite is a source of > concern to me.
Why? (and...perhaps you should define what you mean by 'dependencies') > The number of assertions, less so. I'd just do DESCRIBE > on a test result and then see the failed assertion. Yes, doing DESCRIBE on results is nice, but again: if you have hundreds of test failures, even with DESCRIBE, it could be difficult to see clearly that there are actually only 62 failures that caused a ripple of failures throughout the entire set of suites. > > It seems to me in this case that the *real* test is in > > > (setf d (list a b)) > > (weblocks::render-dirty-widgets) > > (ensure-null d) > > > and the rest is just unnecessary (and confusing) maintenance. > > No, the second assertion is also important, but it likely > has nothing to do with circularity issues and should go into > a separate test case. Yes, this is my point exactly - I didn't mean to suggest that the second assertion shouldn't exist, but that it should only exist in one test (or multiple tests in a render-widget-suite). This test is a good example of what I was talking about - the test failed for me because of different rendering results, not because my changes caused dirty circularity. Since I only had 3 tests to worry about, and 2 of them were the same issue, it was simple to ascertain the truth - but the conclusions I drew in a matter of 15 minutes or so would have taken much longer to come to if I had to filter through hundreds of failed test results. I should also inject here that I'm not griping about the test suite - I was pleasantly suprised to find 700+ test that all passed save one; there's a lot of effort and discipline(!) that went into the suites that is particularly impressive. These are just my observations for the record in case they might be helpful to someone later. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "weblocks" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/weblocks?hl=en -~----------~----~----~----~------~----~------~--~---
